public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: rust-for-linux@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [RFC PATCH 0/3] Initial plumbing for implementing DRM connector APIs in Rust
Date: Sat, 13 Sep 2025 16:57:26 +0000	[thread overview]
Message-ID: <87plbus32o.fsf@protonmail.com> (raw)
In-Reply-To: <20250827-cherubic-tapir-of-wind-5cf0c4@houat>

On Wed, 27 Aug, 2025 08:57:58 +0200 "Maxime Ripard" <mripard@kernel.org> wrote:
> Hi Rahul,
>
> On Wed, Aug 20, 2025 at 04:46:52AM +0000, Rahul Rameshbabu wrote:
>> On Tue, 19 Aug, 2025 11:06:40 +0200 "Maxime Ripard" <mripard@kernel.org> wrote:
>> > Hi Rahul,
>> >
>> > On Mon, Aug 18, 2025 at 05:04:15AM +0000, Rahul Rameshbabu wrote:
>> >> I am working on a drm_connector scoped backlight API in Rust. I have been
>> >> looking through Hans de Goede's previous efforts on this topic to help
>> >> guide my design. My hope is to enable backlight control over external
>> >> displays through DDC or USB Monitor Control Class while also supporting
>> >> internal panels. In parallel, I would like to improve the driver
>> >> probing/selection mechanism when there are different candidates for driving
>> >> a backlight device. This initial RFC is mainly intended to sanity check
>> >> that the plumbing I have chosen for extending the DRM connector
>> >> functionality in Rust seems reasonable.
>> >
>> > It's a great goal, and I had that same discussion with Hans recently
>> > too, but I can't find the link between backling/DDC CI, and Rust. Can
>> > you elaborate?
>> 
>> Hi Maxime,
>> 
>> Sure, let me elaborate on this. You are right that plumbing DDC
>> CI/backlight support at the DRM connector level does not need to be
>> implemented in Rust.
>> 
>> If we look at Hans's proposal, the suggested phase 2 was to add a
>> drm_connector helper function for plumbing a pointer to the backlight
>> device implementation. I had some model differences with regards to how
>> the API would look like, mostly stemming from concerns about providing
>> better runtime overriding of the acpi_video_get_backlight_type based
>> backlight selection. However, I am aligned with the direction of scoping
>> at the drm_connector level. I basically was interested in implementing
>> this helper functionality in Rust instead of C, which is where Rust came
>> into play.
>> 
>> I was also interested in declaring and attaching a drm_property in Rust
>> for controlling properties such as backlight rather than updating the
>> drm_connector declaration in C as an experiment.
>> 
>> Let me know if you feel like this work would be better off as a C
>> implementation. I can also send out a detailed architecture proposal to
>> the mailing list if that would help.
>> 
>> Link: https://lore.freedesktop.org/wayland-devel/0d188965-d809-81b5-74ce-7d30c49fee2d@redhat.com/
>
> Thanks for the explanation.
>
> I'm not sure Rust is at the point where we can use it for the framework.
> If we want to make this work useful, we have to make it consistent and
> usable across all drivers, but we do have drivers for architectures that
> aren't supported by Rust yet (let alone tier 1).
>
> So it feels to me that it would be a bit premature for that work to be
> in Rust. If you do want to use it from a Rust driver though, feel free
> to write bindings for it, that would be a great addition.

Hi Maxime,

Thanks for the follow-up. Sorry for the delay in my response. I was
preparing a slide deck for Kangrejos 2025 (Rust for Linux conference).

https://binary-eater.github.io/kangrejos-2025/

The above discusses the architecture I had in mind in greater detail. I
am working on some last minute tweaks. I wanted to do a couple things
with regards to this topic.

1. Send a high level RFC describing the architecture / functionality
2. In parallel, maybe further evaluate whether Rust could be viable for
   this effort. I hope the slides I put together help.
3. If the discussion in point 2 seems to suggest that Rust is not
   viable, do the core implementation work in C.

Let me know if this seems like a reasonable approach and thank you so
much for taking the time to respond.

Thanks,
Rahul Rameshbabu

>
> Maxime


  reply	other threads:[~2025-09-13 16:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  5:04 [RFC PATCH 0/3] Initial plumbing for implementing DRM connector APIs in Rust Rahul Rameshbabu
2025-08-18  5:04 ` [RFC PATCH 1/3] rust: drm: fix C header references in doc comments Rahul Rameshbabu
2025-08-18  7:58   ` Miguel Ojeda
2025-08-18  5:04 ` [RFC PATCH 2/3] rust: pci: fix incorrect platform " Rahul Rameshbabu
2025-08-18  5:04 ` [RFC PATCH 3/3] rust: drm: Introduce a Connector abstraction Rahul Rameshbabu
2025-08-18  8:23 ` [RFC PATCH 0/3] Initial plumbing for implementing DRM connector APIs in Rust Miguel Ojeda
2025-08-19  9:06 ` Maxime Ripard
2025-08-20  4:46   ` Rahul Rameshbabu
2025-08-27  6:57     ` Maxime Ripard
2025-09-13 16:57       ` Rahul Rameshbabu [this message]
2025-09-17 14:37         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plbus32o.fsf@protonmail.com \
    --to=sergeantsagara@protonmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=lossin@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox