From: Andreas Hindborg <a.hindborg@kernel.org>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>
Cc: <miguel.ojeda.sandonis@gmail.com>, <alex.gaynor@gmail.com>,
<ojeda@kernel.org>, <aliceryhl@google.com>,
<anna-maria@linutronix.de>, <bjorn3_gh@protonmail.com>,
<boqun.feng@gmail.com>, <dakr@kernel.org>,
<frederic@kernel.org>, <gary@garyguo.net>, <jstultz@google.com>,
<linux-kernel@vger.kernel.org>, <lossin@kernel.org>,
<lyude@redhat.com>, <rust-for-linux@vger.kernel.org>,
<sboyd@kernel.org>, <tglx@linutronix.de>, <tmgross@umich.edu>
Subject: Re: [PATCH v3 0/5] rust: time: Convert hrtimer to use Instant and Delta
Date: Fri, 11 Jul 2025 08:13:51 +0200 [thread overview]
Message-ID: <87ple7i7a8.fsf@kernel.org> (raw)
In-Reply-To: <20250711.080013.1402268636571271744.fujita.tomonori@gmail.com> (FUJITA Tomonori's message of "Fri, 11 Jul 2025 08:00:13 +0900")
"FUJITA Tomonori" <fujita.tomonori@gmail.com> writes:
> On Thu, 10 Jul 2025 13:59:17 +0200
> Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
>> This was discussed [1] and consensus was reached that `as_*` iwth pass
>> by value plus a `Copy` bound on the trait is the way to go for this
>> method.
>>
>> [1] https://hackmd.io/ZXXSbxxQRpiWzX61sJFlcg?view#API-Naming-guidelines-for-conversion-functions
>
> Great, thanks!
>
> Would you like me to send a patch for something ― for example, a patch
> that applies the above changes to the current timekeeping-next tree?
>
> Or would you prefer to reset timekeeping-next to an earlier commit for
> a cleaner history, and have me send a patchset based on that?
Yes, we should align the code, so if you can change all the `as_nanos`
to take by value, that would be great.
I already sent the PR for the 6.17 merge window, so please send a new
patch, then we can get it in the next cycle.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-07-11 6:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 13:28 [PATCH v3 0/5] rust: time: Convert hrtimer to use Instant and Delta FUJITA Tomonori
2025-06-10 13:28 ` [PATCH v3 1/5] rust: time: Rename Delta's methods from as_* to into_* FUJITA Tomonori
2025-06-10 13:28 ` [PATCH v3 2/5] rust: time: Replace HrTimerMode enum with trait-based mode types FUJITA Tomonori
2025-06-10 13:28 ` [PATCH v3 3/5] rust: time: Add HrTimerExpires trait FUJITA Tomonori
2025-06-10 13:28 ` [PATCH v3 4/5] rust: time: Make HasHrTimer generic over HrTimerMode FUJITA Tomonori
2025-06-12 13:45 ` Andreas Hindborg
2025-06-10 13:28 ` [PATCH v3 5/5] rust: time: Remove Ktime in hrtimer FUJITA Tomonori
2025-06-16 22:07 ` [PATCH v3 0/5] rust: time: Convert hrtimer to use Instant and Delta FUJITA Tomonori
2025-06-17 8:06 ` Andreas Hindborg
2025-06-17 10:37 ` Andreas Hindborg
2025-06-24 11:08 ` Miguel Ojeda
2025-06-24 11:14 ` Andreas Hindborg
2025-06-24 12:24 ` Miguel Ojeda
2025-06-24 13:11 ` Andreas Hindborg
2025-06-24 13:41 ` FUJITA Tomonori
2025-06-24 17:56 ` Andreas Hindborg
2025-06-24 19:03 ` Andreas Hindborg
2025-06-24 23:20 ` FUJITA Tomonori
2025-06-25 8:19 ` Andreas Hindborg
2025-06-26 0:12 ` FUJITA Tomonori
2025-07-04 7:20 ` Andreas Hindborg
2025-07-10 11:59 ` Andreas Hindborg
2025-07-10 23:00 ` FUJITA Tomonori
2025-07-11 6:13 ` Andreas Hindborg [this message]
2025-06-24 21:13 ` Miguel Ojeda
2025-06-24 23:30 ` FUJITA Tomonori
2025-06-25 8:11 ` Miguel Ojeda
2025-06-25 8:30 ` Andreas Hindborg
2025-06-25 8:28 ` Andreas Hindborg
2025-06-24 11:16 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ple7i7a8.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).