Re: [PATCH 15/79] block: rnull: add `use_per_node_hctx` config option

Alice Ryhl
2026-03-16T14:05:45Z

On Mon, Mar 16, 2026 at 02:57:47PM +0100, Andreas Hindborg wrote:
> "Alice Ryhl" <aliceryhl@google.com> writes:
>
> > On Mon, Feb 16, 2026 at 12:35:02AM +0100, Andreas Hindborg wrote:
> >> Add a configfs attribute to enable per-NUMA-node hardware contexts.
> >> When enabled, the driver creates one hardware queue per NUMA node
> >> instead of the default configuration.
> >>
> >> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> >
> > This and other patches make me think that module parameters should have
> > value() return a copy of the value (and require Copy). For non-copy
> > types, there can be a separate value_ref() method. You would avoid *so*
> > many asterisks by doing that.
>
> Makes sense, I'll send a patch.

Nice!

> >> + use_per_node_hctx: u8 {
> >> + default: 0,
> >> + description:
> >> + "Use per-node allocation for hardware context queues, 0-false, 1-true. Default: 0-false",
> >> + },
> >
> > formatting (rustfmt ignores macros)
>
> This is intentional. The line gets too long if I pull it up, and I don't
> think I can break the string in any way. I think it would require
> changes to the module parameter macro.

Just keep the wrong line. Checkpatch will complain, but it's standard to
ignore that checkpatch warning in C code for long strings to keep them
greppable, so I think it's fine here too.

Alice