RE: [PATCH 62/79] block: rust: add `TagSet::update_hw_queue_count`

Andreas Hindborg
2026-02-17T09:54:43Z

"Ken Kurematsu" <k.kurematsu@nskint.co.jp> writes:

> Hi Andreas,
>
>> -----Original Message-----
>> From: Andreas Hindborg <a.hindborg@kernel.org>
>> Sent: Monday, February 16, 2026 8:36 AM
>> To: Boqun Feng <boqun.feng@gmail.com>; Jens Axboe <axboe@kernel.dk>;
>> Miguel Ojeda <ojeda@kernel.org>; Gary Guo <gary@garyguo.net>; Björn Roy
>> Baron <bjorn3_gh@protonmail.com>; Benno Lossin <lossin@kernel.org>;
>> Alice Ryhl <aliceryhl@google.com>; Trevor Gross <tmgross@umich.edu>;
>> Danilo Krummrich <dakr@kernel.org>; FUJITA Tomonori
>> <fujita.tomonori@gmail.com>; Frederic Weisbecker <frederic@kernel.org>;
>> Lyude Paul <lyude@redhat.com>; Thomas Gleixner <tglx@kernel.org>;
>> Anna-Maria Behnsen <anna-maria@linutronix.de>; John Stultz
>> <jstultz@google.com>; Stephen Boyd <sboyd@kernel.org>; Lorenzo Stoakes
>> <lorenzo.stoakes@oracle.com>; Liam R. Howlett
>> <Liam.Howlett@oracle.com>
>> Cc: linux-block@vger.kernel.org; rust-for-linux@vger.kernel.org;
>> linux-kernel@vger.kernel.org; linux-mm@kvack.org; Andreas Hindborg
>> <a.hindborg@kernel.org>
>> Subject: [PATCH 62/79] block: rust: add `TagSet::update_hw_queue_count`
>>
>> Add a method to `TagSet` that allows changing the number of hardware
>> queues
>> dynamically.
>>
>> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
>> ---
>> rust/kernel/block/mq/tag_set.rs | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/rust/kernel/block/mq/tag_set.rs
>> b/rust/kernel/block/mq/tag_set.rs
>> index 4d00979a83dbd..47a162360e628 100644
>> --- a/rust/kernel/block/mq/tag_set.rs
>> +++ b/rust/kernel/block/mq/tag_set.rs
>> @@ -8,6 +8,7 @@
>> bindings,
>> block::mq::{operations::OperationsVTable, request::RequestDataWrapper,
>> Operations},
>> error::{self, Result},
>> + prelude::*,
>> try_pin_init,
>> types::{ForeignOwnable, Opaque},
>> };
>> @@ -34,7 +35,7 @@ pub struct TagSet<T: Operations> {
>> }
>>
>> impl<T: Operations> TagSet<T> {
>> - /// Try to create a new tag set
>> + /// Try to create a new tag se }t
>
> Is this a typo?
> It looks like an unnecessary ' }'.

Yes, that is a mistake. Thanks!

Best regards,
Andreas Hindborg