From: Andreas Hindborg <nmi@metaspace.dk>
To: Trevor Gross <tmgross@umich.edu>
Cc: "Luis Chamberlain" <mcgrof@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Adam Bratschi-Kaye" <ark.email@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Daniel Gomez" <da.gomez@samsung.com>,
rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: add `module_params` macro
Date: Wed, 28 Aug 2024 03:43:10 +0000 [thread overview]
Message-ID: <87seupwbwe.fsf@metaspace.dk> (raw)
In-Reply-To: <CALNs47vwhV-DRzPbvE22vefaROmjj_5SCLuyQrfKvy=Q4Ou9WQ@mail.gmail.com>
"Trevor Gross" <tmgross@umich.edu> writes:
> On Tue, Aug 27, 2024 at 10:00 AM Andreas Hindborg <nmi@metaspace.dk> wrote:
>>
>> "Trevor Gross" <tmgross@umich.edu> writes:
>>
>> > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg <nmi@metaspace.dk> wrote:
>> >>
>> >> From: Andreas Hindborg <a.hindborg@samsung.com>
>> >>
>> >> This patch includes changes required for Rust kernel modules to utilize
>> >> module parameters. This code implements read only support for integer
>> >> types without `sysfs` support.
>> >
>> > Also, I think the subject line needs an update ("rust: add
>> > `module_params` macro")
>>
>> Well, it is still what it does. Plus few support types. You think it is
>> not descriptive enough?
>
> Maybe it should just say 'Add parameter support to the `module!`
> macro'? The text `module_params` doesn't seem to appear in the patch,
> I was looking for something like `module_params!`.
Right, I'll change it.
BR Andreas
prev parent reply other threads:[~2024-08-28 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 13:34 [PATCH v2] rust: add `module_params` macro Andreas Hindborg
2024-08-24 11:27 ` Trevor Gross
2024-08-24 13:15 ` Benno Lossin
2024-08-24 21:23 ` Trevor Gross
2024-08-25 7:09 ` Benno Lossin
2024-08-28 12:52 ` Andreas Hindborg
2024-08-24 11:30 ` Trevor Gross
2024-08-27 14:00 ` Andreas Hindborg
2024-08-27 19:11 ` Trevor Gross
2024-08-28 3:43 ` Andreas Hindborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seupwbwe.fsf@metaspace.dk \
--to=nmi@metaspace.dk \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=ark.email@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=da.gomez@samsung.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).