From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Abdiel Janulgue" <abdiel.janulgue@gmail.com>
Cc: ojeda@kernel.org, "Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] rust: dma: be consistent in using the `coherent` nomenclature
Date: Tue, 08 Apr 2025 14:27:42 +0200 [thread overview]
Message-ID: <87wmbuhm81.fsf@kernel.org> (raw)
In-Reply-To: <20250326201230.3193329-2-abdiel.janulgue@gmail.com> (Abdiel Janulgue's message of "Wed, 26 Mar 2025 22:11:42 +0200")
"Abdiel Janulgue" <abdiel.janulgue@gmail.com> writes:
> In the kernel, `consistent` and `coherent` are used interchangeably for
> the region described in this api. Stick with `coherent` nomenclature
> to show that dma_alloc_coherent() is being used.
>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@gmail.com>
> ---
> rust/kernel/dma.rs | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
> index 8cdc76043ee7..d3f448868457 100644
> --- a/rust/kernel/dma.rs
> +++ b/rust/kernel/dma.rs
> @@ -89,15 +89,15 @@ pub mod attrs {
> /// Forces contiguous allocation of the buffer in physical memory.
> pub const DMA_ATTR_FORCE_CONTIGUOUS: Attrs = Attrs(bindings::DMA_ATTR_FORCE_CONTIGUOUS);
>
> - /// This is a hint to the DMA-mapping subsystem that it's probably not worth the time to try
> + /// Hints DMA-mapping subsystem that it's probably not worth the time to try
This and the next two edits has nothing to do with coherent/consistent
nomenclature. Please update the commit message to reflect that.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-04-08 12:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 20:11 [PATCH 0/3] Additional fixes for dma coherent allocator Abdiel Janulgue
2025-03-26 20:11 ` [PATCH 1/3] rust: dma: be consistent in using the `coherent` nomenclature Abdiel Janulgue
2025-03-27 22:20 ` Benno Lossin
2025-04-08 12:27 ` Andreas Hindborg [this message]
2025-03-26 20:11 ` [PATCH 2/3] rust: dma: convert the read/write macros to return Result Abdiel Janulgue
2025-03-26 20:48 ` Miguel Ojeda
2025-03-28 11:17 ` Abdiel Janulgue
2025-03-31 12:16 ` Andreas Hindborg
2025-03-27 22:26 ` Benno Lossin
2025-04-08 12:33 ` Andreas Hindborg
2025-04-08 13:34 ` Miguel Ojeda
2025-04-08 19:46 ` Andreas Hindborg
2025-04-08 21:54 ` Benno Lossin
2025-04-08 21:59 ` Danilo Krummrich
2025-04-08 12:29 ` Andreas Hindborg
2025-03-26 20:11 ` [PATCH 3/3] rust: dma: add as_slice/write functions for CoherentAllocation Abdiel Janulgue
2025-03-27 22:31 ` Benno Lossin
2025-03-31 7:23 ` Andreas Hindborg
2025-03-27 23:38 ` Miguel Ojeda
2025-04-08 3:08 ` Alexandre Courbot
2025-04-10 9:02 ` Abdiel Janulgue
2025-04-10 9:52 ` Alexandre Courbot
2025-04-08 12:39 ` Andreas Hindborg
2025-03-26 20:18 ` [PATCH 0/3] Additional fixes for dma coherent allocator Miguel Ojeda
2025-03-26 20:25 ` Abdiel Janulgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmbuhm81.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).