From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Jens Axboe" <axboe@kernel.dk>, "Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] rust: block: convert `block::mq` to use `Refcount`
Date: Thu, 10 Oct 2024 10:41:21 +0200 [thread overview]
Message-ID: <87wmigmjta.fsf@kernel.org> (raw)
In-Reply-To: <20241004155247.2210469-4-gary@garyguo.net> (Gary Guo's message of "Fri, 04 Oct 2024 16:52:24 +0100")
"Gary Guo" <gary@garyguo.net> writes:
> Currently there's a custom reference counting in `block::mq`, which uses
> `AtomicU64` Rust atomics, and this type doesn't exist on some 32-bit
> architectures. We cannot just change it to use 32-bit atomics, because
> doing so will make it vulnerable to refcount overflow. So switch it to
> use the kernel refcount `kernel::sync::Refcount` instead.
>
> There is an operation needed by `block::mq`, atomically decreasing
> refcount from 2 to 0, which is not available through refcount.h, so
> I exposed `Refcount::as_atomic` which allows accessing the refcount
> directly.
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Boqun Feng <boqun.feng@gmail.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Gary Guo <gary@garyguo.net>
Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
prev parent reply other threads:[~2024-10-10 8:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 15:52 [PATCH 0/3] implement `kernel::sync::Refcount` and convert users Gary Guo
2024-10-04 15:52 ` [PATCH 1/3] rust: implement `kernel::sync::Refcount` Gary Guo
2024-10-04 16:34 ` Dirk Behme
2024-10-04 18:51 ` Andreas Hindborg
2024-10-04 19:08 ` Gary Guo
2024-10-04 19:22 ` Andreas Hindborg
2024-10-05 6:04 ` Dirk Behme
2024-10-05 7:40 ` Greg KH
2024-10-05 13:31 ` Gary Guo
2024-10-05 14:26 ` Gary Guo
2024-10-07 12:30 ` Alice Ryhl
2024-10-04 15:52 ` [PATCH 2/3] rust: convert `Arc` to use `Refcount` Gary Guo
2024-10-05 12:06 ` Alice Ryhl
2024-10-05 13:12 ` Gary Guo
2024-10-04 15:52 ` [PATCH 3/3] rust: block: convert `block::mq` " Gary Guo
2024-10-04 16:43 ` Dirk Behme
2024-10-04 18:05 ` Andreas Hindborg
2024-10-05 15:08 ` Gary Guo
2024-10-05 18:47 ` Andreas Hindborg
2024-10-04 18:34 ` Andreas Hindborg
2024-10-04 18:43 ` Gary Guo
2024-10-04 19:18 ` Andreas Hindborg
2024-10-05 7:47 ` Greg KH
2024-10-05 9:48 ` Andreas Hindborg
2024-10-05 10:09 ` Greg KH
2024-10-05 10:10 ` Peter Zijlstra
2024-10-05 10:57 ` Andreas Hindborg
2024-10-05 11:05 ` Miguel Ojeda
2024-10-05 11:59 ` Alice Ryhl
2024-10-05 13:23 ` Gary Guo
2024-10-05 14:56 ` Andreas Hindborg
2024-10-10 8:39 ` Andreas Hindborg
2024-10-10 9:06 ` Andreas Hindborg
2024-10-10 9:48 ` Benno Lossin
2024-10-10 11:13 ` Andreas Hindborg
2024-10-05 14:51 ` Andreas Hindborg
2024-10-10 8:41 ` Andreas Hindborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmigmjta.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).