From: Timur Tabi <ttabi@nvidia.com>
To: "miguel.ojeda.sandonis@gmail.com" <miguel.ojeda.sandonis@gmail.com>
Cc: "ojeda@kernel.org" <ojeda@kernel.org>,
"dakr@kernel.org" <dakr@kernel.org>,
"lossin@kernel.org" <lossin@kernel.org>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] rust: introduce sfile macro for easier code tracing
Date: Wed, 4 Jun 2025 23:12:22 +0000 [thread overview]
Message-ID: <8d78b126676f71a112a538f79b80ce6a6f513ce7.camel@nvidia.com> (raw)
In-Reply-To: <CANiq72kEA-hzqkrXxSUk4bp63NFG=TxmQU+9+yiJsoyuQr86Qg@mail.gmail.com>
On Wed, 2025-06-04 at 00:15 +0200, Miguel Ojeda wrote:
> On Wed, Jun 4, 2025 at 12:05 AM Timur Tabi <ttabi@nvidia.com> wrote:
> >
> > But won't that cause the functions to always be compiled and exist in the kernel, even if
> > sfile!()
> > is never used?
>
> Not necessarily, why?
If I move the function outside of the macro, I need to declare the function as "pub". If I don't do
this, then other modules that use kernel::sfile won't compile.
But in doing so, the function is compiled as a stand-alone function, even though the macro doesn't
actually use it. The compiler apparently re-inlines the function in the macro call.
Compare the two:
Without pub: https://rust.godbolt.org/z/T9YKs3c1r
With pub: https://rust.godbolt.org/z/qEb3x7vbj
I've never actually seen a compiler do this, to be honest, but it makes a lot of sense. If you
compare the example::main function on both links, they are identical. But the version with "pub"
also has a full implementation of rfind_const() that is just not used.
next prev parent reply other threads:[~2025-06-04 23:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 18:45 [PATCH] rust: introduce sfile macro for easier code tracing Timur Tabi
2025-05-29 20:14 ` Benno Lossin
2025-06-03 17:15 ` Timur Tabi
2025-06-03 21:54 ` Benno Lossin
2025-05-29 20:21 ` Miguel Ojeda
2025-06-03 18:15 ` Timur Tabi
2025-06-03 21:58 ` Benno Lossin
2025-06-03 22:05 ` Timur Tabi
2025-06-03 22:15 ` Miguel Ojeda
2025-06-04 23:12 ` Timur Tabi [this message]
2025-06-05 3:20 ` Miguel Ojeda
2025-06-03 22:15 ` Miguel Ojeda
2025-06-03 23:29 ` Timur Tabi
2025-06-04 10:28 ` Miguel Ojeda
2025-06-04 15:16 ` Benno Lossin
2025-06-04 15:41 ` Miguel Ojeda
2025-06-05 6:05 ` Greg KH
2025-06-04 20:38 ` Timur Tabi
2025-06-05 6:07 ` Greg KH
2025-06-05 15:02 ` Timur Tabi
2025-06-05 15:21 ` gregkh
2025-06-05 15:38 ` Miguel Ojeda
2025-06-05 16:42 ` gregkh
2025-06-05 17:39 ` Miguel Ojeda
2025-06-06 15:50 ` Miguel Ojeda
2025-05-30 3:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d78b126676f71a112a538f79b80ce6a6f513ce7.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).