From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21FFF3D0C16 for ; Mon, 20 Jul 2026 10:34:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543658; cv=none; b=hAaEFM3XUQ9qYo60ctcJCP72DhfOcwIVQsYfsniCLIxUwHYUJ0T22eBkGgyKHl50TtS44HTtvYtsyQE2quXefs6QwQoPYCMYXgPISpuYQAohExvwaUEAxGwIt0Ip08qddFpYvHYoz2bqLP+thVR06dkw/nHAQkueB79FhTPLVPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543658; c=relaxed/simple; bh=nfb9wr1IkGcOE/xOB087/ooy5UHg3twujjs8ono0J50=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=eWridvEZFmYDDF1wnVY03f5EP+eQo/64oWtH1clHuaXdH8Gw4Wde3KdYURXpdg/YnnJvSmyiKmiXM0+LyWLWb+Pt8+LuftUZT/DNClhW36kN+tTMgXYLc8yTPFA1veI0VotXUO2BSxFXXEjYHQuDmd1dy25FN5exG35PkVyWszs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hwhQA1Ms; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BNRIc87N; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hwhQA1Ms"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BNRIc87N" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K9w4lw2189483 for ; Mon, 20 Jul 2026 10:34:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=hwhQA1MsitD5btdd JqsR13zTYhd8UuvDpj3UXwKAUPj0TaA5iOiiU4fX3Dl0h9mYVWFrxWQnM99+iJ4g ANjDaLE4FRRQuJu80TqDoXekVCzaxkVLwtmfcI6PJATKmGrTqGCbOwiZ6OYuFEI8 jOh4DmrE1VTsI8P1lcjSb7gPcsmo/WiWwBtB1y7hkqOgW7fehnlM2UbgKLWXfV/O 0zqdnt3bPWdecuslW7LhPv33ZFqcWXsEp5FqPXPeNcHWCq9XKRAlNqK/qi2+P7In a+NLjlbpaVpOdDkCchhe5vLBtRiXesNklo53o2kwUF+jj/a2DAXWu6+yKeS9pNvl II1jsg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fgd04vrrx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 10:34:15 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92ef13b61bcso1679203985a.1 for ; Mon, 20 Jul 2026 03:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784543655; x=1785148455; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=BNRIc87NYMxJVo/m9e2bflvbdwGq5m7I/r0D+AwC4b+bvVgkr0zqYHnvpWqSvwymyA +hPIibLtNvYri2ep0vqgfboYTsh4nftHSoiKS7XMmH3g6KOykEPKcYK5Jkn5wZhObRuN wv3qls1Nn9GpF7S2qLaJhIr6rf/SkMcIMFPFc9Rjyn1FHmqlunqG72nhO0+IP4qnges6 NguYYljeJ3hQBwlenGiR5Itz+nbuRVrYU9ZgPreE6l4EIEIDFDKYfoKDXAzjDS8bHhvH YFXgZWE157a//uWG8wSSp3ivpovLfVc9w7slG8vthSuiBeYj43MQXF/1LPlo/PoUcCjx OOhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784543655; x=1785148455; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=DTX9ZfDnvPlA7HDlWMrk8NSyCWXftbdbIxxaJOwNJH580ewHKMBePCNuVaX+gBAC6d UV5CQ/FcuApgqxvxg+0H2rdEyQpfnQbNFJ+8FcsOhrAePAzaov3XltFDGpyGrJ/HKfwj Zy680+S4LZR4N3EZYE7qVWRHO/wPzI/W3hDai96roWYtF18/o2tNE8majpwpbmNPKpM3 s1ol0YXxtgPESS/R5VkEV8vZcJq04at7Rb49/DUaXstX+Y6spAi6ZMGzeH6e4E0CAnCf gwbbRyrvvy42TwE9zUSI0ysLcW7vO4jEGA5T1y9IIwSeQhZqdsc+sLMJX1nEMAWY89es bhPA== X-Forwarded-Encrypted: i=1; AHgh+Rp+Rd5dnu26tXyYg/RSYRA0i5OhN8n8pRNdb4gOEQ57KLhilwh9y6jUGGs1OFDugaogW+XRqhljiKKXR4sldQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzzTGQUc4YmGsW+UeLV7T2v1EBxnReTZMwmjCPOe9v7OEl78zUu YhDkUWnc5lvwl97zybPi483yEmGiXDxzOEyirpp1CwLWInu92GbEuOD4ITzoHhR5V3ADgRyZZ1o jNSWlgiMgtffAhp480Cv/N26l9wJ+zdycyz43YfrBpY62gysrJwFGBZZ64Ka6yXLW6I8fxw== X-Gm-Gg: AfdE7clElc517YGfDnSTYvwh1iLMc6Br5cnHCzjQ+j4DK0nQX7QzldpNbT39232JdiI VQGwEnufJw/o/GhXAn/LtUppkTv1woC5Cvq41nWERpFCFbQPQVlIelOH6RqkVvnW0DTH0GgMY0x /qnuuDEnuvBQ8IInaqaWbWjYSmRrmI57ZSvy0MMTq+sfJRHreFj1a/fJ31JUYOW1uHHM1Q+JILw RzI8mtWx4uAzFft0i5B0gjohYUXxClbRueq2iaNds/muhDKA+nr30zqVLGgTi2VqxLJZBFk2vHw FoeFjRL9fO8yaxMiWa2fJW3fd0uemnS9xuU9ktB7Ipk4/GTfdoO6TamuxDL81KlXJXPI/NcAq80 1ORetNm36wiM33B45vV9+i8n4PtuRFHqG223495MqEXEYlQCQK5fkQvBLSxx/DTdNgtutA+d4Vb L3jF5+MbwNWLNLHt6j0Nr0MtVLA1gm64sLddKT1HCv49Cyo5VcPfRy1FV1/hVqj7JzdHc= X-Received: by 2002:ac8:5d88:0:b0:519:55c0:a1e5 with SMTP id d75a77b69052e-5213c8e3aa1mr118701161cf.8.1784543655160; Mon, 20 Jul 2026 03:34:15 -0700 (PDT) X-Received: by 2002:ac8:5d88:0:b0:519:55c0:a1e5 with SMTP id d75a77b69052e-5213c8e3aa1mr118700261cf.8.1784543654369; Mon, 20 Jul 2026 03:34:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c17009adff3sm439489566b.2.2026.07.20.03.34.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 03:34:13 -0700 (PDT) Message-ID: <8d86ca46-d329-4e65-a7bf-2b79fccddf05@oss.qualcomm.com> Date: Mon, 20 Jul 2026 12:34:10 +0200 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH 8/8] media: ov2740: remove NULL reg_write callback To: Sakari Ailus , Link Mauve Cc: Srinivas Kandagatla , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Tianshu Qiu , Bingbu Cao , Mauro Carvalho Chehab , Aaro Koskinen , Andreas Kemnade , Roger Quadros , Tony Lindgren , Lee Jones , Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , "Vaibhaav Ram T.L" , Kumaravel Thiagarajan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Praveen Teja Kundanala , Kalyani Akula , Michal Simek , Alexandre Belloni , Joshua Kinard , Antoniu Miclaus , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Daniel Lezcano , Johan Hovold , Ronald Claveau , Salah Triki , Yury Norov , David Carlier , Achim Gratz , Alexander Sverdlin , Patrick Wicki , Markus Heidelberg , Markus Perkins , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Bjorn Helgaas , Abd-Alrhman Masalkhi , Chen Ni , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, mfd@lists.linux.dev, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev, rust-for-linux@vger.kernel.org References: <20260715175229.24672-1-linkmauve@linkmauve.fr> <20260715175229.24672-9-linkmauve@linkmauve.fr> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=POs/P/qC c=1 sm=1 tr=0 ts=6a5df9a7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=2y0c4oOAfBMx015UTLoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDExNyBTYWx0ZWRfXxKGFPfUhibh1 CvmDlVPCIqrH2mVj8PNLbU+P+FSVtDsAS4x1xz3k6F/KN9pAba8KLu/ZuLzQ1360Zve+O6k8cgs IEqzi4Y9g7xFs0iLpDqjWr9dVaEUalSp2Tu1gepMkA3nieZIxeLNc4TLyjCqqB3TFR4nq874jc+ AMMmLf/IfPnJ6GPDdTzO8XJOB/3YHMpjnn6VEFiTnJl7MFYmSxYoCcyPH5r2LI0k+fAU/CxpWST 9hGEjYnhs+m4288Pxc1UTjIDJcPiDB/xA3RpVN/b2D/Kr+K14jEniHYstjdYV6FV3/xA5QaISyn 7XCW6+ArQLz9woaGTFShP5/Bu5KcYTCExd2FHWGDmAn5jzZ/P65UVMeRNXlCaDLO2Jkkm67UE+B 4BTD2ALgKlxbfMwSC5gdLUXDRQx3vObm4vII126dh0VLVHeOA95db0WTyIjGMpmDqNMh8k7u3nW Cg/jatd7/K5SQkoBt8g== X-Proofpoint-ORIG-GUID: IHcoPfLLFJYWER2P6MdIITUoMaKVHVYX X-Proofpoint-GUID: IHcoPfLLFJYWER2P6MdIITUoMaKVHVYX X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDExNyBTYWx0ZWRfX6bsc5UmOrKx8 ByQWAzgZNoW7SKopA5OKsme1f0Y7jGihIuvVy0U5kGKBbuVXve8ckNrf95uHGUNZVhQLJH0H5bv wRw8hc3on1TAmqF7iU2Bgv6mS8ZCLCc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1011 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200117 Hi Sakari, On 20-Jul-26 11:39, Sakari Ailus wrote: > Hi, > > On Wed, Jul 15, 2026 at 07:52:24PM +0200, Link Mauve wrote: >> This field is already initialized to NULL, so there is no reason to >> write it again. >> >> This prevents it from appearing while grepping for reg_write in the >> future. >> >> Signed-off-by: Link Mauve > > I believe we need a real name here. We don't need a real name / official name here, just a "known identity", IOW not "anonoymous1234" since Link has clearly is using Link Mauve as their internet identity (given they went through the trouble of registering it as a domain) I believe the S-o-b here is fine as is. See: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 where the "real name" policy was weakened to "known identity". Regards, Hans > >> --- >> drivers/media/i2c/ov2740.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c >> index fb590dfadda1..799eca4023da 100644 >> --- a/drivers/media/i2c/ov2740.c >> +++ b/drivers/media/i2c/ov2740.c >> @@ -1271,7 +1271,6 @@ static int ov2740_register_nvmem(struct i2c_client *client, >> nvmem_config.compat = true; >> nvmem_config.base_dev = dev; >> nvmem_config.reg_read = ov2740_nvmem_read; >> - nvmem_config.reg_write = NULL; >> nvmem_config.priv = nvm; >> nvmem_config.stride = 1; >> nvmem_config.word_size = 1; > > I think it'd be nicer to do the initialisation in variable declaration -- > all the information is available already there. >