From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC616F524; Thu, 14 Mar 2024 16:27:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710433652; cv=none; b=iYwfGVBmpxPMWQPtc+TTmlY7zabJ6Tm1OGcvAvF0zrwPXxHaAB0RlizYTPRVTuCR6YDZvO2LvNeUbSIa6thorfFuDH4PAMVdNIDuYUoiWKnulrt8Nc4jFyWOx/PrOE6CMfNwnhk2WabkbFjneaQbvAV57+WdfaoS9taWyBVdd9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710433652; c=relaxed/simple; bh=vwoyE2mDyn9On8hrLTCnfN060DQ8TxSfqTAxI+RAnKw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VOJqwB59/kke0iVPGAd9xnLuYOiMhKHcQtQ2s058z6tJq0pqmr72hIc+aqsM5D3Nl+rQ2u8DfTOSX2liyT4yZ5GQ4pMO0a4jBIAgIhZfvnfG1ZlHrpKBkjf+UWKHDYOCzIxY0c7nEIG7Ct9rT0fvmsdCMvAdaatZkbCc6ofpfuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=NvR543C0; arc=none smtp.client-ip=185.70.43.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="NvR543C0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1710433648; x=1710692848; bh=vwoyE2mDyn9On8hrLTCnfN060DQ8TxSfqTAxI+RAnKw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=NvR543C0oZfacPkUN+ozGEYwwwBKN1k0iTFQliPRarb7BOLfs0qRAk7zcFkzv1aSk eroiTKoVMPV68qZyjv69B8NQhRG9WxKF5DxkS8+tYyonuapvzhzX7pkRLwsmAJfQH5 coxxoBid4P2e2ml6xRwYoprRuDh2kylDcCX50806fYMnuZEWtf1WRZTwIW/cmYMuCr 4x4V/HKhiKZgzcHVYpsjfN3yLaV1oGuqhKx86KIvXw8NidMMuk4mV5Kp5AHMiYAF1f eQGyWrTpsojGtXDIAStk47pGDQPCLJXB8lN3VrRWcRN8wWud/lV6+gv02Q3ZPku28k Pvt4e4ZKWVsig== Date: Thu, 14 Mar 2024 16:27:09 +0000 To: Matt Gilbride , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Greg Kroah-Hartman , =?utf-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Christian Brauner From: Benno Lossin Cc: Rob Landley , Davidlohr Bueso , Michel Lespinasse , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/6] rust: rbtree: add `RBTreeIteratorMut` Message-ID: <94cced92-7cb0-4c6c-934f-7f9190abe3a1@proton.me> In-Reply-To: <20240219-b4-rbtree-v2-4-0b113aab330d@google.com> References: <20240219-b4-rbtree-v2-0-0b113aab330d@google.com> <20240219-b4-rbtree-v2-4-0b113aab330d@google.com> Feedback-ID: 71780778:user:proton Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/19/24 12:48, Matt Gilbride wrote: > From: Wedson Almeida Filho >=20 > Add mutable Iterator implementation (`RBTreeIteratorMut`) for `RBTree`, > allowing iteration over (key, value) pairs in key order. Only values are > mutable, as mutating keys implies modifying a node's position in the tree= . >=20 > Mutable iteration is used by the binder driver during shutdown to > clean up the tree maintained by the "range allocator" [1]. >=20 > Link: https://lore.kernel.org/rust-for-linux/20231101-rust-binder-v1-6-08= ba9197f637@google.com/ [1] > Signed-off-by: Wedson Almeida Filho > Signed-off-by: Matt Gilbride > Reviewed-by: Alice Ryhl > Tested-by: Alice Ryhl The comments from patch 3 also apply here. --=20 Cheers, Benno