public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>, lyude@redhat.com
Cc: rust-for-linux@vger.kernel.org
Subject: Re: Maybe make Sashiko emails opt-in please?
Date: Thu, 23 Apr 2026 13:24:13 -0700	[thread overview]
Message-ID: <971a606f-3319-46c5-ad84-a250f8044d53@nvidia.com> (raw)
In-Reply-To: <DI05ND6E449C.3TZEG1R8O7N72@nvidia.com>

On 4/22/26 6:48 PM, Alexandre Courbot wrote:
> On Thu Apr 23, 2026 at 10:10 AM JST, lyude wrote:
... 
> I agree that this kind of tool should be opt-in. Maybe we can make it
> such as Sachiko reviews are only sent to the author of a patch if they
> also Cc'd some sachiko@ address that acts as an opt-in?

I love the idea of Sashiko remaining silent, unless it was specifically
Cc'd.

* Developers prefer tools that can "pre-review" and catch issues *before*
they post publicly.

    * checkpatch.pl does that.
    * sashiko could do that too! It could be triggered by a direct
      email sent only to sashiko.

* While debate continues about the false positive rate of AI-powered
code reviews vs. their value, there is *no* debate that the rate is
high enough to bother a significant fraction of kernel devs. We need
to respect that and configure the tool usage to be less, well, annoying.

This is important.

> 
> Sachiko can still do reviews and post them on its web interface even
> without it, but the author would not be explicitly notified in that
> case.

Yes, exactly.

I'm very impressed with sashiko, and want to get its feedback--in select
scenarios. Not on every patchset I post. And I believe that this is a
fairly common, widespread preference.
 

thanks,
-- 
John Hubbard


  reply	other threads:[~2026-04-23 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  1:10 Maybe make Sashiko emails opt-in please? lyude
2026-04-23  1:48 ` Alexandre Courbot
2026-04-23 20:24   ` John Hubbard [this message]
2026-04-23 22:16     ` Roman Gushchin
2026-04-24 23:22       ` Miguel Ojeda
2026-04-26 23:38       ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=971a606f-3319-46c5-ad84-a250f8044d53@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=lyude@redhat.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox