From: Jens Axboe <axboe@kernel.dk>
To: Alice Ryhl <aliceryhl@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Andreas Hindborg <a.hindborg@samsung.com>
Cc: linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: sort includes in bindings_helper.h
Date: Fri, 9 Aug 2024 07:07:37 -0600 [thread overview]
Message-ID: <975158d8-4f26-4b5c-9cc7-eec15d901eb6@kernel.dk> (raw)
In-Reply-To: <20240809064222.3527881-1-aliceryhl@google.com>
On 8/9/24 12:42 AM, Alice Ryhl wrote:
> Dash has ascii value 45 and underscore has ascii value 95, so to
> correctly sort the includes, the underscore should be last.
This commit message lacks an explanation for why the change is
being done. Yes it states that it brings the headers in ascii
sort order, but WHY?
--
Jens Axboe
next prev parent reply other threads:[~2024-08-09 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 6:42 [PATCH] rust: sort includes in bindings_helper.h Alice Ryhl
2024-08-09 12:58 ` Miguel Ojeda
2024-08-09 13:38 ` Alice Ryhl
2024-08-09 13:01 ` Danilo Krummrich
2024-08-09 13:19 ` Alice Ryhl
2024-08-09 13:07 ` Jens Axboe [this message]
2024-08-09 13:16 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975158d8-4f26-4b5c-9cc7-eec15d901eb6@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.hindborg@samsung.com \
--cc=aliceryhl@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).