From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CFBF1B0F1C; Thu, 28 Nov 2024 14:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732804208; cv=pass; b=QYSYdpNmq8bwWq+G401JGU7uNe1oHRZzavK/5UwBcUQv2uyHqelLzOqCW8cm4y/gW36SiInTEanHDiUQ1fHNqxpZ81YhyOi7C9Auy+V2WqdfL3WFD5IPVlEluKKcCzHIpH1pZdJg47AR9JTaNlMXsaoHAa36UQFKgcy1P/mdU1o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732804208; c=relaxed/simple; bh=XHzXBNIpch0n5ki+RPoBM5UiqGnlg+tEwyb+937RF6Y=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=coPEi2raeRskTMINpka0ytI/FXB+HsG0P0q6nW1WlzzGqo9sVxZWMFDxOFHuN/cwslKezTrqhDwUdpe/lwNTvlPHBZBP5HQDefnkm7WenhVQrPj5rr0IUPl+/6CgApDWf/mwSb0WFexw6sG7lFubiK26qWeYZlCHknJBz36O2Z4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=ddJZZXHs; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="ddJZZXHs" ARC-Seal: i=1; a=rsa-sha256; t=1732804175; cv=none; d=zohomail.com; s=zohoarc; b=W5/xYku4emSx1qcpNWsy12LZbkUfN+GMf9rKQE+Dzporw3Ajo35wC0MT9FJUM6wyZ7ZuNu0KL5QrB2ERh96EBSCPMDbxmhcEwMNnW0b71sRXD1IQ8KIlVMYLoTawYWmxtQdG7QhowSs2HONpHmN/qJhwMDGMa8c6Li3RoJLnOD0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732804175; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ESdq7+vJq5NINh85EeRXpbCJuG9FayiFw/PgAnZgLEs=; b=VIkRBhotgG0ZJKVPfUIUglytu4eNDSGs8a7xtuVmCVRl4O2gpMdvDyDET1o2ztYG9n/7hK87m6PrfDV3j/rUku6yikstwYFWnIqGB4xV13bjO2Vvwg+5gzoBxvPiogmzQ92V9gCldZy2RUPJMFjN3MtgEBgtauEVB1Cy3OMnLuQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1732804175; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=ESdq7+vJq5NINh85EeRXpbCJuG9FayiFw/PgAnZgLEs=; b=ddJZZXHspf6q0EUBidd2iL/XwYOY+h2oUpyfDfQ+Vaxrrad88ea00chA04etnd5F gcnB5B4oSBH8iVrpqVHq5cRvfSpU6MlcjHTDRHxfKmgg7BaDZ13MOGdJBSeMdKEFmKZ +aJeai6WpCcHYsNYjmvHlyfV8b108UdnEHfdoqtY= Received: by mx.zohomail.com with SMTPS id 1732804173824507.02096353782724; Thu, 28 Nov 2024 06:29:33 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [WIP RFC v2 28/35] rust: drm/kms: Add RawPlane::framebuffer() From: Daniel Almeida In-Reply-To: <20240930233257.1189730-29-lyude@redhat.com> Date: Thu, 28 Nov 2024 11:29:18 -0300 Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Asahi Lina , Danilo Krummrich , mcanal@igalia.com, airlied@redhat.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , open list Content-Transfer-Encoding: quoted-printable Message-Id: References: <20240930233257.1189730-1-lyude@redhat.com> <20240930233257.1189730-29-lyude@redhat.com> To: Lyude Paul X-Mailer: Apple Mail (2.3826.200.121) X-ZohoMailClient: External Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: >=20 > Returns the Framebuffer currently assigned in an atomic plane state. A bit unrelated to this patch, but can you have more than one = framebuffer active?=20 i.e.: for things like overlays, etc >=20 > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/plane.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/rust/kernel/drm/kms/plane.rs = b/rust/kernel/drm/kms/plane.rs > index cd5167e6441f1..15efa53fda8d3 100644 > --- a/rust/kernel/drm/kms/plane.rs > +++ b/rust/kernel/drm/kms/plane.rs > @@ -31,6 +31,7 @@ > StaticModeObject, > atomic::*, > crtc::*, > + framebuffer::*, > }; >=20 > /// The main trait for implementing the [`struct drm_plane`] API for = [`Plane`] > @@ -521,6 +522,13 @@ fn atomic_helper_check( > ) > }) > } > + > + /// Return the framebuffer currently set for this plane state > + #[inline] > + fn framebuffer(&self) -> Option<&Framebuffer<::Driver>> { > + // SAFETY: The layout of Framebuffer is identical to `fb` > + unsafe { self.as_raw().fb.as_ref().map(|fb| = Framebuffer::from_raw(fb)) } > + } > } > impl RawPlaneState for T {} >=20 > --=20 > 2.46.1 >=20 >=20 LGTM =E2=80=94 Daniel