From: "Sergio González Collado" <sergio.collado@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
Miguel Ojeda <ojeda@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Randy Dunlap <rdunlap@infradead.org>,
rust-for-linux@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Nathan Chancellor <nathan@kernel.org>,
David Laight <david.laight.linux@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
x86@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] kunit: fix longest symbol length test
Date: Mon, 7 Jul 2025 19:09:16 +0200 [thread overview]
Message-ID: <CAA76j90WCAm0Zm5vcv5S3mBkZVzSUCC4S5N2F9G20G5WUsFirg@mail.gmail.com> (raw)
In-Reply-To: <20250707093836.GC1099709@noisy.programming.kicks-ass.net>
Hello,
The initial goal was to verify that a KSYM_NAME_LEN of 512 was
working as expected. It also fixed an issue in
/x86/tools/insn_decoder_test.c.
This fix is indeed quite trivial, I just implemented the suggested
ideas. Amend the test using KSYM_NAME_LEN-8 doesn't really seem to me
to fix the underlying problem (I also don't know if there is any magic
value).
Take into account that he actual warnings that have been reported in
the CI ("Please increase KSYM_NAME_LEN both in kernel and kallsyms.c")
are not from this test, but from
https://elixir.bootlin.com/linux/v6.15/source/scripts/kallsyms.c#L146,
the test has just make that warning evident. Would removing that
comment be a better solution?
Nevertheless, acknowledging that we don't have full control over the
symbols' names, is also an interesting insight.
I will be happy to address the issue in one way or another, no problem there.
Regards,
Sergio
next prev parent reply other threads:[~2025-07-07 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 20:18 [PATCH v3 RESEND] kunit: fix longest symbol length test Sergio González Collado
2025-07-07 9:38 ` Peter Zijlstra
2025-07-07 17:09 ` Sergio González Collado [this message]
2025-07-10 19:30 ` Rae Moar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA76j90WCAm0Zm5vcv5S3mBkZVzSUCC4S5N2F9G20G5WUsFirg@mail.gmail.com \
--to=sergio.collado@gmail.com \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=david.laight.linux@gmail.com \
--cc=davidgow@google.com \
--cc=jpoimboe@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rmoar@google.com \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=x86@kernel.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).