Re: [PATCH] kbuild: rust: add `rustupoverride` target

[David Gow <davidgow@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

On Fri, 15 Dec 2023 at 06:23, Miguel Ojeda <ojeda@kernel.org> wrote:
>
> When setting up the Rust support via `rustup`, one may use an override
> in order to select the right version of the Rust toolchain.
>
> The current instructions at Documentation/rust/quick-start.rst assume
> one is using an in-tree kernel build (i.e. no `O=`) [1]. We would like
> to provide also the way to do so for `O=` builds, but ideally in a way
> that keeps the one-liner copy-pastable and without duplication [2].
>
> Thus provide a new Make target, `rustupoverride`, that sets it up for
> the user given their build options/variables.
>
> Link: https://lore.kernel.org/rust-for-linux/20231207084846.faset66xzuoyvdlg@vireshk-i7/ [1]
> Link: https://lore.kernel.org/rust-for-linux/CANiq72=mvca8PXoxwzSao+QFbAHDCecSKCDtV+ffd+YgZNFaww@mail.gmail.com/ [2]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> Viresh may send a patch on top of this to refer to `rustupoverride`
> from the Quick Start guide in `Documentation/rust` -- that one should
> probably be applied right after this one.
>

This worked fine for me testing the 1.74.1 upgrade, thanks.

Tested-by: David Gow <davidgow@google.com>

Would having similar targets for bindgen help? What about having this
install rust-src? Updating / installing those required a lot more
looking up of documentation (and then adding --force), so it'd be nice
if there were some way to do a similar override or make target.

Cheers,
-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]