Re: [PATCH v2 2/3] rust: macros: add macro to easily run KUnit tests

[David Gow <davidgow@google.com>]

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]

On Tue, 29 Oct 2024 at 20:28, Boqun Feng <boqun.feng@gmail.com> wrote:
>
> Hi David,
>
> On Tue, Oct 29, 2024 at 05:24:18PM +0800, David Gow wrote:
> > From: José Expósito <jose.exposito89@gmail.com>
> >
> > Add a new procedural macro (`#[kunit_tests(kunit_test_suit_name)]`) to
> > run KUnit tests using a user-space like syntax.
> >
> > The macro, that should be used on modules, transforms every `#[test]`
> > in a `kunit_case!` and adds a `kunit_unsafe_test_suite!` registering
> > all of them.
> >
> > The only difference with user-space tests is that instead of using
> > `#[cfg(test)]`, `#[kunit_tests(kunit_test_suit_name)]` is used.
> >
> > Note that `#[cfg(CONFIG_KUNIT)]` is added so the test module is not
> > compiled when `CONFIG_KUNIT` is set to `n`.
> >
> > Reviewed-by: David Gow <davidgow@google.com>
> > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> > [Updated to use new const fn.]
> > Signed-off-by: David Gow <davidgow@google.com>
> > ---
> >
> > Changes since v1:
> > https://lore.kernel.org/lkml/20230720-rustbind-v1-2-c80db349e3b5@google.com/
> > - Rebased on top of rust-next
> > - Make use of the new const functions, rather than the kunit_case!()
> >   macro.
> >
> > ---
> >  MAINTAINERS          |  1 +
> >  rust/kernel/kunit.rs | 11 +++++++++++
> >  rust/macros/lib.rs   | 29 +++++++++++++++++++++++++++++
> >  3 files changed, 41 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b77f4495dcf4..b65035ede675 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12433,6 +12433,7 @@ F:    Documentation/dev-tools/kunit/
> >  F:   include/kunit/
> >  F:   lib/kunit/
> >  F:   rust/kernel/kunit.rs
> > +F:   rust/macros/kunit.rs
>
> I cannot find this file in this series, and it's not in the current
> rust-next either.
>
> (Did you do the same thing as I sometimes did: forget to `git add` a new
> file?)
>

Whoops! Thanks for catching this: I somehow managed to unstage it
while editing things. Fixed in v3:
https://lore.kernel.org/linux-kselftest/20241030045719.3085147-6-davidgow@google.com/

Cheers,
-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5294 bytes --]