* Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep
2023-09-28 20:14 [PATCH] rust: Use grep -Ev rather than relying on GNU grep Matthew Maurer
@ 2023-09-28 21:00 ` Trevor Gross
2023-09-28 21:04 ` Martin Rodriguez Reboredo
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Trevor Gross @ 2023-09-28 21:00 UTC (permalink / raw)
To: Matthew Maurer
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, rust-for-linux, linux-kernel
On Thu, Sep 28, 2023 at 4:14 PM Matthew Maurer <mmaurer@google.com> wrote:
>
> While GNU grep supports '\|' when in basic regular expression mode, not
> all grep implementations do (notably toybox grep, used to build the
> Android kernel, does not). Switching to grep -Ev enables extended
> regular expresions which includes support for the '|' operator.
>
> Signed-off-by: Matthew Maurer <mmaurer@google.com>
> ---
Reviewed-by: Trevor Gross <tmgross@umich.edu>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep
2023-09-28 20:14 [PATCH] rust: Use grep -Ev rather than relying on GNU grep Matthew Maurer
2023-09-28 21:00 ` Trevor Gross
@ 2023-09-28 21:04 ` Martin Rodriguez Reboredo
2023-10-02 7:51 ` Alice Ryhl
2023-10-15 20:05 ` Miguel Ojeda
3 siblings, 0 replies; 6+ messages in thread
From: Martin Rodriguez Reboredo @ 2023-09-28 21:04 UTC (permalink / raw)
To: Matthew Maurer, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, rust-for-linux, linux-kernel
On 9/28/23 17:14, Matthew Maurer wrote:
> While GNU grep supports '\|' when in basic regular expression mode, not
> all grep implementations do (notably toybox grep, used to build the
> Android kernel, does not). Switching to grep -Ev enables extended
> regular expresions which includes support for the '|' operator.
>
> Signed-off-by: Matthew Maurer <mmaurer@google.com>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep
2023-09-28 20:14 [PATCH] rust: Use grep -Ev rather than relying on GNU grep Matthew Maurer
2023-09-28 21:00 ` Trevor Gross
2023-09-28 21:04 ` Martin Rodriguez Reboredo
@ 2023-10-02 7:51 ` Alice Ryhl
2023-10-02 8:18 ` Alice Ryhl
2023-10-15 20:05 ` Miguel Ojeda
3 siblings, 1 reply; 6+ messages in thread
From: Alice Ryhl @ 2023-10-02 7:51 UTC (permalink / raw)
To: Matthew Maurer
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
rust-for-linux, linux-kernel
On Thu, Sep 28, 2023 at 10:14 PM Matthew Maurer <mmaurer@google.com> wrote:
>
> While GNU grep supports '\|' when in basic regular expression mode, not
> all grep implementations do (notably toybox grep, used to build the
> Android kernel, does not). Switching to grep -Ev enables extended
> regular expresions which includes support for the '|' operator.
>
> Signed-off-by: Matthew Maurer <mmaurer@google.com>
LGTM. I tested this in my Android build.
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Tested-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep
2023-10-02 7:51 ` Alice Ryhl
@ 2023-10-02 8:18 ` Alice Ryhl
0 siblings, 0 replies; 6+ messages in thread
From: Alice Ryhl @ 2023-10-02 8:18 UTC (permalink / raw)
To: Matthew Maurer
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
rust-for-linux, linux-kernel
On Mon, Oct 2, 2023 at 9:51 AM Alice Ryhl <aliceryhl@google.com> wrote:
>
> On Thu, Sep 28, 2023 at 10:14 PM Matthew Maurer <mmaurer@google.com> wrote:
> >
> > While GNU grep supports '\|' when in basic regular expression mode, not
> > all grep implementations do (notably toybox grep, used to build the
> > Android kernel, does not). Switching to grep -Ev enables extended
> > regular expresions which includes support for the '|' operator.
> >
> > Signed-off-by: Matthew Maurer <mmaurer@google.com>
>
> LGTM. I tested this in my Android build.
Also tested in a non-Android build. Works both places.
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Tested-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep
2023-09-28 20:14 [PATCH] rust: Use grep -Ev rather than relying on GNU grep Matthew Maurer
` (2 preceding siblings ...)
2023-10-02 7:51 ` Alice Ryhl
@ 2023-10-15 20:05 ` Miguel Ojeda
3 siblings, 0 replies; 6+ messages in thread
From: Miguel Ojeda @ 2023-10-15 20:05 UTC (permalink / raw)
To: Matthew Maurer
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, rust-for-linux, linux-kernel
On Thu, Sep 28, 2023 at 10:14 PM Matthew Maurer <mmaurer@google.com> wrote:
>
> While GNU grep supports '\|' when in basic regular expression mode, not
> all grep implementations do (notably toybox grep, used to build the
> Android kernel, does not). Switching to grep -Ev enables extended
> regular expresions which includes support for the '|' operator.
>
> Signed-off-by: Matthew Maurer <mmaurer@google.com>
Applied to `rust-next` (with typo fixed) -- thanks everyone!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 6+ messages in thread