From: Alice Ryhl <aliceryhl@google.com>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Benno Lossin" <lossin@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-pci@vger.kernel.org,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Dirk Behme" <dirk.behme@de.bosch.com>
Subject: Re: [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and handlers
Date: Mon, 11 Aug 2025 14:43:12 +0200 [thread overview]
Message-ID: <CAH5fLggOqsrob-h2v8c5hsnMquJZhXJ2euAub2ia2fjj=NY8Vg@mail.gmail.com> (raw)
In-Reply-To: <AF48133C-BD57-4EEF-8E4A-ABEECB8A5C49@collabora.com>
On Mon, Aug 11, 2025 at 2:38 PM Daniel Almeida
<daniel.almeida@collabora.com> wrote:
>
>
> >> Also, I was getting tons of “unreachable_pub” warnings
> >> otherwise, FYI.
> >
> > If you got unreachable_pub warnings, then you are missing re-exports.
> >
> > Alice
>
> The re-exports are as-is in the current patch, did I miss anything? Because I
> don’t think so.
>
> In particular, should the irq module itself be private?
No, the end-user should be able to write
use kernel::irq::Flags;
so the irq module needs to be public.
Alice
next prev parent reply other threads:[~2025-08-11 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 0:32 [PATCH v8 0/6] rust: add support for request_irq Daniel Almeida
2025-08-11 0:32 ` [PATCH v8 1/6] rust: irq: add irq module Daniel Almeida
2025-08-11 0:32 ` [PATCH v8 2/6] rust: irq: add flags module Daniel Almeida
2025-08-11 9:57 ` Alice Ryhl
2025-08-11 0:32 ` [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and handlers Daniel Almeida
2025-08-11 10:58 ` Alice Ryhl
2025-08-11 11:47 ` Daniel Almeida
2025-08-11 11:55 ` Alice Ryhl
2025-08-11 12:37 ` Daniel Almeida
2025-08-11 12:43 ` Alice Ryhl [this message]
2025-08-11 12:55 ` Daniel Almeida
2025-08-11 13:04 ` Danilo Krummrich
2025-08-11 0:32 ` [PATCH v8 4/6] rust: irq: add support for threaded " Daniel Almeida
2025-08-11 11:02 ` Alice Ryhl
2025-08-11 0:32 ` [PATCH v8 5/6] rust: platform: add irq accessors Daniel Almeida
2025-08-11 0:32 ` [PATCH v8 6/6] rust: pci: " Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH5fLggOqsrob-h2v8c5hsnMquJZhXJ2euAub2ia2fjj=NY8Vg@mail.gmail.com' \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=joelagnelf@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).