From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C44E2877F4 for ; Mon, 21 Jul 2025 14:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753107466; cv=none; b=fy8fD5LNHL13iRS1qpESfTvhQLoZJC6zlobC9qAJv6CdWbze0Tt1x4xb58JFMaDvv4+2RKNhRkl8RZCL8ePmBmy9txgndIN8DqkNdbWz+VLjbUILK+XpbRSG8WjK7ReuSLWz0fXy0tjbh8fZX7Y/0+m9KaJzQh5AviO3kFv84BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753107466; c=relaxed/simple; bh=jx62/zzI69MGOw6Q1ltR2MwUC388v3A5IGqMmpKVPmI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=c530s/djAb3Lm8RtZfZtH2clHgtQgXzsR27gaP7kVx2nAKCJa7Jo3p+b//CNYNcG2h1zFWP48FbqlfmX0pmVJrH7aDc2ObcndM1nJJtyqjWfpKIPmDOzFgZsnLr7FHRTWyXUnDpxCw9UDcQkXcdVmC9juRzM0fo0CdKJW71IFak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D++7aQYF; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D++7aQYF" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4537edf2c3cso46065855e9.3 for ; Mon, 21 Jul 2025 07:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753107462; x=1753712262; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aHTz2f/tCB5gJfHRUHusAnrHo0WkysiHKc8/HuxZcyk=; b=D++7aQYFr5L68qNWwL/6zhUENYiKjmqUo1TJh2Z+2mF60qdLzy6CIZ+pGTEMtQM+HK 7YKl+TD5gKVwZ3EMqoX75nloA/j9A4+Ics/VJADr3c7MCue2dUtz2eDhJiPOeIDmj4Kj woZ0BiltwOVZoVbDkT4AoIoq5NZlBAUoQu0I4sWUvmi6YoSdApdLKoHzn9h2mz+DKMKw 0DZYegFgRd+N6AxhW69vAmAJhKuWrX6zrBIEr4IL5AUpPzx8ZHobPTEvPFucknhKpSJ/ LMdwYMp2C5v812DMHr7QH0aWt7+fR96mCMpCJGDu18HnPppnpjQ7ayqkJvnUcBAr2RGI EXMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753107462; x=1753712262; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aHTz2f/tCB5gJfHRUHusAnrHo0WkysiHKc8/HuxZcyk=; b=bvJ9NBc19kxXNI3+pJeTgr686WvnpFOL4XVk99ThQ6BsYzxHPxb5ZRhoP1AX30eCwF 5B2yQHOsPjkAdLStrG1YMB8KcwDAaS3mYfzZMKTMT3KJZ0Uhl5VMyExCgUGFv3KCrZbL Nq3ZkwSK4RD1FWMHZn0jQnxVlh2xMu+Yojy0VRp9JmeFvc7iu4Pr4fAFX7JHT1GPCXza QL+VTUqiokyMczu1jrGpAiEXPtBZIzeWGHSR81CPp8+URzm+8U6VqKjU8gnW0++rKdI5 uL0CfOMCn7tmyDdvNaC7cV2Q06VzF9WJPMdhhRrEca9ab5vhEB0BhZCNbM2r7i5ItppH blrQ== X-Forwarded-Encrypted: i=1; AJvYcCWwK4HZV0S5kGAc41GWYqtLvv0i+RSXo4Iuu2hAYmlezSLHsoyWi2nwEs+7SWl2XYWZTesmkHmDpBnhZx8rGw==@vger.kernel.org X-Gm-Message-State: AOJu0YxJwxP2IU/9t0c56LXXcN6Vgfqcn9S7jdVCRPJ+F5BUwdIVsVCf /d03U4AmUDQsC8nphvqaLm5/5u5FKPfDVhM+OeX0YjdArdpM/Sew8hia5/ogrDSU94EWq/S4Wgo km3BKbJGdKC1Qn0y7SpHcwhRcWcFnm6q7N8HqJgUQ X-Gm-Gg: ASbGncvP4PARwZS2+/KAWgtH2rjCDd3zEeWmFtOX0UXvDGmBTWgfmfMtNe88ogF2CuV xymADS4HF2Ed+EtMBZUgbBu3ZcLIU7NZ1C9B8ME8lSRM/gi7zdE209V51v1thRVggZwqOxybnk2 97xoetFUREyX42E19iIFd/qC2wsF7fhW87nL+C9yz/JbxIjVEgH4oTJL3ZmJrXk7/49YNveS30Y jVxeCQQ6yqvtTqLImAnsggusgMg+qbnE6e+7g== X-Google-Smtp-Source: AGHT+IGjLzZ7/Km2FCbSNRsrArfXJV2GEMgIhjJN78UwwjSKkWJY+F2cHXQv40vfc3kSfYwQzfjjab4StDfPm4kGNEg= X-Received: by 2002:a05:600c:5253:b0:456:1efa:8fe9 with SMTP id 5b1f17b1804b1-4562e03a678mr216153965e9.2.1753107462190; Mon, 21 Jul 2025 07:17:42 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250715-topics-tyr-request_irq2-v7-3-d469c0f37c07@collabora.com> <202507170718.AVqYqRan-lkp@intel.com> <9834736F-F70F-4290-9DE8-755A6D0D5EB8@collabora.com> In-Reply-To: <9834736F-F70F-4290-9DE8-755A6D0D5EB8@collabora.com> From: Alice Ryhl Date: Mon, 21 Jul 2025 16:17:29 +0200 X-Gm-Features: Ac12FXzqc3WLYmS_rx0F_dtIhtQQ4LQMKVOtCM3xLb6rdTs9AmutrC95-1kYQiY Message-ID: Subject: Re: [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and handlers To: Daniel Almeida Cc: kernel test robot , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Thomas Gleixner , Bjorn Helgaas , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Benno Lossin , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 17, 2025 at 6:21=E2=80=AFPM Daniel Almeida wrote: > > > > > On 16 Jul 2025, at 20:45, kernel test robot wrote: > > > > Hi Daniel, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on 3964d07dd821efe9680e90c51c86661a98e60a0f] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Almeida/r= ust-irq-add-irq-module/20250715-232121 > > base: 3964d07dd821efe9680e90c51c86661a98e60a0f > > patch link: https://lore.kernel.org/r/20250715-topics-tyr-request_ir= q2-v7-3-d469c0f37c07%40collabora.com > > patch subject: [PATCH v7 3/6] rust: irq: add support for non-threaded I= RQs and handlers > > config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/2= 0250717/202507170718.AVqYqRan-lkp@intel.com/config) > > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87= f0227cb60147a26a1eeb4fb06e3b505e9c7261) > > rustc: rustc 1.88.0 (6b00bc388 2025-06-23) > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20250717/202507170718.AVqYqRan-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202507170718.AVqYqRan-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > >>> error[E0425]: cannot find value `SHARED` in module `flags` > > --> rust/doctests_kernel_generated.rs:4790:58 > > | > > 4790 | let registration =3D Registration::new(request, flags::SHA= RED, c_str!("my_device"), handler); > > | ^^^^^^ not= found in `flags` > > | > > help: consider importing this constant > > | > > 3 + use kernel::mm::virt::flags::SHARED; > > | > > help: if you import `SHARED`, refer to it directly > > | > > 4790 - let registration =3D Registration::new(request, flags::SHA= RED, c_str!("my_device"), handler); > > 4790 + let registration =3D Registration::new(request, SHARED, c_= str!("my_device"), handler); > > | > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > > > This is a single character fix, so I am waiting for the discussion on the= cover > letter [0] to advance before sending a new version. > > [0] https://lore.kernel.org/all/DBCQKJIBVGGM.1R0QNKO3TE4N0@kernel.org/#t My suggestion is to make the flags module private and re-export the Flags type from the irq module. That way you don't have to write use kernel::irq::flags::Flags; Alice