From: Alice Ryhl <aliceryhl@google.com>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] rust: types: avoid `as` casts
Date: Fri, 8 Nov 2024 17:34:22 +0100 [thread overview]
Message-ID: <CAH5fLghF-B3eGnN3yQ_eZRWWMQa-CLDZea6hgFM3uS=n-GNyzg@mail.gmail.com> (raw)
In-Reply-To: <20241108-borrow-mut-v3-2-b7144945714e@gmail.com>
On Fri, Nov 8, 2024 at 4:46 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Replace `as` casts with `cast{,_mut}` calls which are a bit safer.
>
> In one instance, remove an unnecessary `as` cast without replacement.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
One question below, but either way:
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> @@ -333,13 +334,13 @@ impl<T: 'static> ForeignOwnable for Arc<T> {
> type Borrowed<'a> = ArcBorrow<'a, T>;
>
> fn into_foreign(self) -> *const core::ffi::c_void {
> - ManuallyDrop::new(self).ptr.as_ptr() as _
> + ManuallyDrop::new(self).ptr.as_ptr().cast_const().cast()
What's up with this cast_const?
Alice
next prev parent reply other threads:[~2024-11-08 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 15:46 [PATCH v3 0/6] rust: add improved version of `ForeignOwnable::borrow_mut` Tamir Duberstein
2024-11-08 15:46 ` [PATCH v3 1/6] rust: arc: use `NonNull::new_unchecked` Tamir Duberstein
2024-11-08 15:46 ` [PATCH v3 2/6] rust: types: avoid `as` casts Tamir Duberstein
2024-11-08 16:34 ` Alice Ryhl [this message]
2024-11-08 16:39 ` Tamir Duberstein
2024-11-08 15:46 ` [PATCH v3 3/6] rust: arc: split unsafe block, add missing comment Tamir Duberstein
2024-11-08 15:46 ` [PATCH v3 4/6] rust: change `ForeignOwnable` pointer to mut Tamir Duberstein
2024-11-08 15:46 ` [PATCH v3 5/6] rust: reorder `ForeignOwnable` items Tamir Duberstein
2024-11-08 15:46 ` [PATCH v3 6/6] rust: add improved version of `ForeignOwnable::borrow_mut` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH5fLghF-B3eGnN3yQ_eZRWWMQa-CLDZea6hgFM3uS=n-GNyzg@mail.gmail.com' \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).