From: Alice Ryhl <aliceryhl@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: macros: fix documentation of the paste! macro
Date: Mon, 21 Oct 2024 10:19:09 +0200 [thread overview]
Message-ID: <CAH5fLghGiW=7WvZSbjE7vXXrOBhUSrrGaCDdnHiTkp79Trr=TA@mail.gmail.com> (raw)
In-Reply-To: <20241019072208.1016707-1-pbonzini@redhat.com>
On Sat, Oct 19, 2024 at 9:22 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> One of the example in this section uses a curious mix of the constant
> and function declaration syntaxes; fix it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The `pub_no_prefix` examples usually defines constants rather than
functions. I guess it is a function here to showcase the :lower
modifier, which doesn't make sense for constants? I guess that makes
sense.
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Alice
next prev parent reply other threads:[~2024-10-21 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 7:22 [PATCH] rust: macros: fix documentation of the paste! macro Paolo Bonzini
2024-10-21 8:19 ` Alice Ryhl [this message]
2024-10-21 18:14 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH5fLghGiW=7WvZSbjE7vXXrOBhUSrrGaCDdnHiTkp79Trr=TA@mail.gmail.com' \
--to=aliceryhl@google.com \
--cc=pbonzini@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).