From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A38F155382 for ; Tue, 9 Jul 2024 09:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720518739; cv=none; b=WNsKmFpmHlfaZeZNcULgbT9Ev5zt+q5ghoTnOfkx+SHDeMjoDBi5XG6hnpD98a+y3QfrvfwuXTVJspB8uBztWT1kas5Aloh0yPVvn1f6Mlo+vmGJ6JEtuOxJX9ADnoGTGGFNVlTa5Njr+bjkEEkRt9IR4JHF9EvTMIhdliA3Cmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720518739; c=relaxed/simple; bh=i7LfNc6qq1+aDEVX+3WD/8s4yDV8gC7rFYVgqcVfLhg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Ho+AdisvfdP4XE7e4FKMy3z6F5VPterxBaUHJyfXC5cDwApQv4OFxU2jpMu2foMSekh6JBGexVGBJE6STRS8+m55clKtO2AVxQ+2yB236qyg5HoRdZzc7lVw/45tvMj6QtWj+Nv+//75NI/wmvaYa6ItfwjZnDiVGlJDOtEzN4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ztAxLAxN; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ztAxLAxN" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3679df4cb4cso2991166f8f.0 for ; Tue, 09 Jul 2024 02:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720518736; x=1721123536; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i7LfNc6qq1+aDEVX+3WD/8s4yDV8gC7rFYVgqcVfLhg=; b=ztAxLAxNlBzqlkn7Jjt0h/icaXPqSYMxgUBPinhXx0DifV8VImw8Ff8yH5/dIUzdk4 Dyk0Rh3hDq5urZnm9xhToYmomHFL7iqh+UboHGlKW64Rmw7tl+D8iidF/b/DHAyUt964 17RNWo8MmJokxTn84sfUZ8demr7q5E4AbRhOCJaVZs4FzgNzdeZhfsU/DlEkZF0eElu3 RjcZ9AE6gaGV7Klo0XoLKdWOvA9CKUmLSViqIm3OFzll8KESFT1LQ6C22Mi5GE1Sdl/0 D62Kq2xZs3A05mnayE7u/FOkFAFDL8/S2zCAb+cna7ptkMoHPqsPg/8CiRVVOmbQEA6k bCIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720518736; x=1721123536; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7LfNc6qq1+aDEVX+3WD/8s4yDV8gC7rFYVgqcVfLhg=; b=rSSpKB9Tj60dSwH0TZ+ZyFB4NDQxpjsSzvIjTuoixPRBi/uNxlx2r9DCiO+2Oh87G5 Cm/w0M/AXeB0jdqi1Iy8QcAHmZC5ebmssOEDROA5eK5MvjzdjMrU7BYTw0QaKgXmHlpG 1iadUUyUUw1d30Cb+6V7xsEq/6LeNWi+CieUnLq2nP5jeuoEEVShI7yimIUnu/FOq/ok PEhxvO7vUWFRHdedR3yiSgbRV8B2hiHkFd74UsTy5i3OChEyORNMHGCxxER3ERp7Pr8f 6ZoFu0aMI/peF+j78jUdOqGA+OZGzN2Ja86K7jK5rY+ENjFSG0Cq9jV2uxrPsX8OBORa IyBg== X-Forwarded-Encrypted: i=1; AJvYcCUak6C158omu4txFGokDu3jPuuVsu5kR3dgX73a1EuXkLSeYUapKSwDaF7PfzX7quSU12OPQpi7HaoS2feoRgJtSXWzCvlSOa+opOZz84Y= X-Gm-Message-State: AOJu0YwlsE3Iyxa6C4RVs7BTiW8DWYIjPhLMswV5FoL/kISB90kiTYD0 qyskHpd30tuAcH7PU4v73L/dk6Ta6UVoFmzWH5iTeAQIGHX17Eqp12bNwCGB13B4uq398Np9kiJ sp1wzkK/zod7nd3GgO999l/0TLYpgHDKYDBBr X-Google-Smtp-Source: AGHT+IEmN00CynNCsDDhXsM0XpdwEU/G9mbSqcBJsKaThKIblLct7tNNCUBwvT2H0N0PDa2zNXTh5YziYvGRh1xvDus= X-Received: by 2002:adf:ef43:0:b0:366:df3f:6f9c with SMTP id ffacd0b85a97d-367d29476bamr1590756f8f.3.1720518735880; Tue, 09 Jul 2024 02:52:15 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240704-shadow-call-stack-v3-0-d11c7a6ebe30@google.com> <20240704-shadow-call-stack-v3-2-d11c7a6ebe30@google.com> <20240704-unless-cache-8a971c244348@spud> In-Reply-To: From: Alice Ryhl Date: Tue, 9 Jul 2024 11:52:04 +0200 Message-ID: Subject: Re: [PATCH v3 2/2] rust: add flags for shadow call stack sanitizer To: Sami Tolvanen Cc: Conor Dooley , Catalin Marinas , Will Deacon , Jamie Cunliffe , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Ard Biesheuvel , Marc Zyngier , Mark Rutland , Mark Brown , Nick Desaulniers , Kees Cook , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Valentin Obst , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 9, 2024 at 2:10=E2=80=AFAM Sami Tolvanen wrote: > > On Thu, Jul 4, 2024 at 10:17=E2=80=AFAM Conor Dooley w= rote: > > > > For these security related options, like CFI_CLANG or RANDSTRUCT, I'm > > inclined to say that RUST is actually what should grow the depends on. > > That way it'll be RUST that gets silently disabled in configs when patc= h > > 1 gets backported (where it is mostly useless anyway) rather than SCS > > nor will it disable SCS when someone enables RUST in their config, > > instead it'd be a conscious choice. > > I agree, we shouldn't silently disable hardening features when Rust is en= abled. That definitely wasn't my intention. I'll update it for v4. Alice