From: Alice Ryhl <aliceryhl@google.com>
To: Guangbo Cui <2407018371@qq.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
"Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [PATCH v4 2/2] rust: align Debug implementation for Box with Display
Date: Tue, 5 Nov 2024 10:49:40 +0100 [thread overview]
Message-ID: <CAH5fLgjO9=r5GMv2hXjPmRB8HAB-7EELhgB2NM2DQvw7h3HjMQ@mail.gmail.com> (raw)
In-Reply-To: <tencent_2E70D3E99973A54BB6C3590393365CFA6B0A@qq.com>
On Mon, Nov 4, 2024 at 3:07 PM Guangbo Cui <2407018371@qq.com> wrote:
>
> Ensure consistency between `Debug` and `Display` for `Box` by
> updating `Debug` to match the new `Display` style.
>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Guangbo Cui <2407018371@qq.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
next prev parent reply other threads:[~2024-11-05 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241104140514.877185-1-2407018371@qq.com>
2024-11-04 14:06 ` [PATCH v4 1/2] rust: Implement Display for Box Guangbo Cui
2024-11-05 9:49 ` Alice Ryhl
2024-11-04 14:06 ` [PATCH v4 2/2] rust: align Debug implementation for Box with Display Guangbo Cui
2024-11-05 9:49 ` Alice Ryhl [this message]
2024-11-08 10:40 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH5fLgjO9=r5GMv2hXjPmRB8HAB-7EELhgB2NM2DQvw7h3HjMQ@mail.gmail.com' \
--to=aliceryhl@google.com \
--cc=2407018371@qq.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).