[PATCH v4 1/2] rust: Implement Display for Box

[PATCH v4 1/2] rust: Implement Display for Box

[Guangbo Cui]

Currently `impl Display` is missing for `Box<T, A>`, as a result,
things like using `Box<..>` directly as an operand in `pr_info!()`
are impossible, which is less ergonomic compared to `Box` in Rust
std.

Therefore add `impl Display` for `Box`.

Suggested-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://github.com/Rust-for-Linux/linux/issues/1126
Signed-off-by: Guangbo Cui <2407018371@qq.com>
---
 rust/kernel/alloc/kbox.rs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs
index d69c32496..a496a866d 100644
--- a/rust/kernel/alloc/kbox.rs
+++ b/rust/kernel/alloc/kbox.rs
@@ -427,6 +427,16 @@ fn deref_mut(&mut self) -> &mut T {
     }
 }
 
+impl<T, A> fmt::Display for Box<T, A>
+where
+    T: ?Sized + fmt::Display,
+    A: Allocator,
+{
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        <T as fmt::Display>::fmt(&**self, f)
+    }
+}
+
 impl<T, A> fmt::Debug for Box<T, A>
 where
     T: ?Sized + fmt::Debug,
-- 
2.34.1

Re: [PATCH v4 1/2] rust: Implement Display for Box

[Alice Ryhl]

On Mon, Nov 4, 2024 at 3:06 PM Guangbo Cui <2407018371@qq.com> wrote:
>
> Currently `impl Display` is missing for `Box<T, A>`, as a result,
> things like using `Box<..>` directly as an operand in `pr_info!()`
> are impossible, which is less ergonomic compared to `Box` in Rust
> std.
>
> Therefore add `impl Display` for `Box`.
>
> Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/1126
> Signed-off-by: Guangbo Cui <2407018371@qq.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

[PATCH v4 2/2] rust: align Debug implementation for Box with Display

[Guangbo Cui]

Ensure consistency between `Debug` and `Display` for `Box` by
updating `Debug` to match the new `Display` style.

Acked-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Guangbo Cui <2407018371@qq.com>
---
 rust/kernel/alloc/kbox.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs
index a496a866d..49c24727f 100644
--- a/rust/kernel/alloc/kbox.rs
+++ b/rust/kernel/alloc/kbox.rs
@@ -443,7 +443,7 @@ impl<T, A> fmt::Debug for Box<T, A>
     A: Allocator,
 {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt::Debug::fmt(&**self, f)
+        <T as fmt::Debug>::fmt(&**self, f)
     }
 }
 
-- 
2.34.1

Re: [PATCH v4 2/2] rust: align Debug implementation for Box with Display

[Alice Ryhl]

On Mon, Nov 4, 2024 at 3:07 PM Guangbo Cui <2407018371@qq.com> wrote:
>
> Ensure consistency between `Debug` and `Display` for `Box` by
> updating `Debug` to match the new `Display` style.
>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Guangbo Cui <2407018371@qq.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH v4 2/2] rust: align Debug implementation for Box with Display

[Danilo Krummrich]

On Mon, Nov 04, 2024 at 10:06:42PM +0800, Guangbo Cui wrote:
> Ensure consistency between `Debug` and `Display` for `Box` by
> updating `Debug` to match the new `Display` style.
> 
> Acked-by: Danilo Krummrich <dakr@kernel.org>

The ACK was for patch 1 -- this patch I haven't seen before obviously.

However, you can keep it. For both:

Acked-by: Danilo Krummrich <dakr@kernel.org>

> Signed-off-by: Guangbo Cui <2407018371@qq.com>
> ---
>  rust/kernel/alloc/kbox.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs
> index a496a866d..49c24727f 100644
> --- a/rust/kernel/alloc/kbox.rs
> +++ b/rust/kernel/alloc/kbox.rs
> @@ -443,7 +443,7 @@ impl<T, A> fmt::Debug for Box<T, A>
>      A: Allocator,
>  {
>      fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> -        fmt::Debug::fmt(&**self, f)
> +        <T as fmt::Debug>::fmt(&**self, f)
>      }
>  }
>  
> -- 
> 2.34.1
>