From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21EBE17F4 for ; Mon, 2 Oct 2023 07:52:12 +0000 (UTC) Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19F5BBF for ; Mon, 2 Oct 2023 00:52:11 -0700 (PDT) Received: by mail-vk1-xa34.google.com with SMTP id 71dfb90a1353d-495cf1bf9f9so6084464e0c.2 for ; Mon, 02 Oct 2023 00:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696233130; x=1696837930; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0eB1JHsdEJVi5+OIbOyuQwr2jpiM2fDRqI2qLCnxqC4=; b=lOawnfVvwurlGTERAfCT4nN4sN8YNb//Rhno00eUkh/EMlMMBwsZc/C52164FgYi2B ElQmNb4QFVQ7toDcsHFYfwca6DRTb57AWxnA/SXCpeW+f7Vh7p6Dlqbfcy3alYaEK261 AuLjMZI5UP2MiSnOKtNctfDWty4A4LVl8biAEa3fPyoST2PdIU0AqDK3xX0yeDZq0/yU 3pyqTzYyxzSTqH3Z6mLYiukRqzw/o2qyAI3PfiSzPZL0ScLVBrCCYwQYZ0S0sx3prehL r1FsrQYD1y/6NUZXGa4vGeULZtvWmk6w7l7Nh9muHRhvjP5grRz7ZXkvJKcZpJnPIeAZ ApDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696233130; x=1696837930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0eB1JHsdEJVi5+OIbOyuQwr2jpiM2fDRqI2qLCnxqC4=; b=gbIZhlkpZXSMpa3RD+VQUCYnLZR5sTOyC9sKu+cXjRpE5jcjhmvN8bKzL/ZiRPdMMT q3cyjx0BVhTGZZxcARgodK/XlOz98fAwHI9Z0tzcKpwnURT/RX+Set5EXm5D+dezldvV GV77epW1trhvO5Fr2V78Qes5EKNgPfRqIwb2I0q0s8uq6kVbXrUD/YAtF92JvtbOPrWK fZl4DPnT4C/Dpeo6oJPL3C9PgDrt73VJyZgvwYqFG/D/dfpXxVaBZdkCPGq3wquTieon V0ZfB91C1u/WCL9skQZ97FokKDB9eX9rl4G/0vyKKkF+uiRUFci5HQDqjxAlkWJOZ5h5 Lu9w== X-Gm-Message-State: AOJu0Yz+h/rm55Jzs0gAJbtVMxzaVy066AwYrTPIpivrDDovRhQjgdis VaNCH95OHe0cqdu6Vh5y8ZcmsK2unS835O5X35ayjQ== X-Google-Smtp-Source: AGHT+IHZB51YF7QTx3t7DDgFWlsKziT1a7v9b77HG6jtZQj1Bi+P05ewtbDn3c7BD6d6mOHABX16dzqMmdw4k+2s4SQ= X-Received: by 2002:a1f:c8c4:0:b0:499:dec9:e1a7 with SMTP id y187-20020a1fc8c4000000b00499dec9e1a7mr5746398vkf.10.1696233129914; Mon, 02 Oct 2023 00:52:09 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230928201421.2296518-1-mmaurer@google.com> In-Reply-To: <20230928201421.2296518-1-mmaurer@google.com> From: Alice Ryhl Date: Mon, 2 Oct 2023 09:51:59 +0200 Message-ID: Subject: Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep To: Matthew Maurer Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Sep 28, 2023 at 10:14=E2=80=AFPM Matthew Maurer wrote: > > While GNU grep supports '\|' when in basic regular expression mode, not > all grep implementations do (notably toybox grep, used to build the > Android kernel, does not). Switching to grep -Ev enables extended > regular expresions which includes support for the '|' operator. > > Signed-off-by: Matthew Maurer LGTM. I tested this in my Android build. Reviewed-by: Alice Ryhl Tested-by: Alice Ryhl