From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FF3C433EF for ; Mon, 9 May 2022 17:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239799AbiEIR4m (ORCPT ); Mon, 9 May 2022 13:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239785AbiEIR4l (ORCPT ); Mon, 9 May 2022 13:56:41 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3998F2BFBF5 for ; Mon, 9 May 2022 10:52:44 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id t25so17996321ljd.6 for ; Mon, 09 May 2022 10:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VAaeELHVcQouTEd0XSCIAgD8jqgghoqAvViW4eNJ0ec=; b=b4o6yjanW6bwSXzeQddKdzJxs16LrwT2UIXAETG9ofvsVHdkcnTr0T5o6JTUSUSE2i qgKhEe/Z5Xcja1V2L0Ue+Ehk04kB2pz9pB82cVQgO4nOKfeuxKNE7ZICwRtrlSHV16Hw 9+nUcwNaRkCd/xkufp5ozkCgdLhZhB1SK+7yBNQVXdtA2Vz1Hm7UikX9VjShaRZmrcjo RfhzezkdcQuRk7C2Bwo/Ph8L1kFONuZVoW5r0wh7jyQY2m44LBYr2tsA+1VzbA94c3nX IWMAZGr+UJW++q+lNKw7iUm90EVcYp8LIeNNadEwWcFLagXSZ2Xx2ESyUnGyoaBHSeZB ou8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VAaeELHVcQouTEd0XSCIAgD8jqgghoqAvViW4eNJ0ec=; b=UnYyqi/NZubpJ7q9Dt6i9qfpIJnrX74vWk31Y1AIsTeZ1MpbwsieWN6nnuo7bbu06L F/cjp7YhfReG6KaB7R/tspIFNUdB7GssCxKWFdCN8h7dHlpr88Dt4IBLRZTadF/aA/Lj ZGTCmdug+dE36xMqGi0xi/9wZvivFXYmq69LD295j3fpUTtVRaaminqkZf2CEffWkdkX akR/x6rg5OEqpURudQee1E3EIesObluY7Rr++U/V/ut4tJJV4z84i+KzQ4XfLym3aNIY bBd7HsaoPyiNcJKuPNpe3Dtiz8l27Y7xnLNVxZ9KRwqTiX8NLP2WgafHEnhDIWpnvr/7 S/RA== X-Gm-Message-State: AOAM533nPnoM4UBIGX6G5qIyFX9I3RI45wlqzd5h7tlcQMECsgwAAYav w7pAoUWWJmeiD9ypsV9ayIEClea4qSWyIfgsaWSFqA== X-Google-Smtp-Source: ABdhPJxLDecK/fKBw2N/qZ9TbLTDtmzVJuxz6GHpR6z+gjd7Z7RShlYqQPsE9j+pLQmgJXqupOfPVeK3DlL9oESmh5A= X-Received: by 2002:a2e:9345:0:b0:24b:451:7ce1 with SMTP id m5-20020a2e9345000000b0024b04517ce1mr11278276ljh.258.1652118762240; Mon, 09 May 2022 10:52:42 -0700 (PDT) MIME-Version: 1.0 References: <20220507052451.12890-1-ojeda@kernel.org> <20220507052451.12890-24-ojeda@kernel.org> <202205070050.A870AEAC6@keescook> In-Reply-To: From: Todd Kjos Date: Mon, 9 May 2022 10:52:30 -0700 Message-ID: Subject: Re: [PATCH v6 23/23] [RFC] drivers: android: Binder IPC in Rust To: Greg Kroah-Hartman Cc: Kees Cook , Miguel Ojeda , Linus Torvalds , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Jarkko Sakkinen , Wedson Almeida Filho , Alex Gaynor , Finn Behrens , Sven Van Asbroeck , Gary Guo , Wayne Campbell , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On Sat, May 7, 2022 at 1:13 AM Greg Kroah-Hartman wrote: > > On Sat, May 07, 2022 at 12:55:17AM -0700, Kees Cook wrote: > > On Sat, May 07, 2022 at 07:24:21AM +0200, Miguel Ojeda wrote: > > > From: Wedson Almeida Filho > > > > > > A port to Rust of the Android Binder IPC mechanism. > > > > > > This module is a work in progress and will be sent for review later > > > on, as well as separately from the Rust support. > > > > Is any functionality missing for this driver compared to the C driver? > > There is no binderfs support, which would be a major regression if it > were to be added. > > And odds are the new binder additions in the past few months are > probably not included here either. > > There is a binder regression test in Android that can be run to test all > of this to see what is missing. That should be a good test of > compatibility. There are a set of tests in the Android tree at frameworks/libs/native/binder/tests, but just booting and having a usable device with this version replacing the C version is pretty impressive. Can you boot and run a real device with this? > > thanks, > > greg k-h