rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rust: devres: remove unused import
@ 2025-07-04 20:11 Tamir Duberstein
  2025-07-04 20:23 ` Danilo Krummrich
  2025-07-05 15:12 ` Danilo Krummrich
  0 siblings, 2 replies; 4+ messages in thread
From: Tamir Duberstein @ 2025-07-04 20:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
	Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross
  Cc: rust-for-linux, linux-kernel, Tamir Duberstein

As far as I can tell, this was never used.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 rust/kernel/devres.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
index d0e6c6e162c2..dff443908278 100644
--- a/rust/kernel/devres.rs
+++ b/rust/kernel/devres.rs
@@ -47,7 +47,7 @@ struct DevresInner<T> {
 /// # Examples
 ///
 /// ```no_run
-/// # use kernel::{bindings, c_str, device::{Bound, Device}, devres::Devres, io::{Io, IoRaw}};
+/// # use kernel::{bindings, device::{Bound, Device}, devres::Devres, io::{Io, IoRaw}};
 /// # use core::ops::Deref;
 ///
 /// // See also [`pci::Bar`] for a real example.

---
base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
change-id: 20250704-cstr-include-devres-151c26d36bbc

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: devres: remove unused import
  2025-07-04 20:11 [PATCH] rust: devres: remove unused import Tamir Duberstein
@ 2025-07-04 20:23 ` Danilo Krummrich
  2025-07-04 20:30   ` Tamir Duberstein
  2025-07-05 15:12 ` Danilo Krummrich
  1 sibling, 1 reply; 4+ messages in thread
From: Danilo Krummrich @ 2025-07-04 20:23 UTC (permalink / raw)
  To: Tamir Duberstein
  Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Miguel Ojeda, Alex Gaynor,
	Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, rust-for-linux,
	linux-kernel

On 7/4/25 10:11 PM, Tamir Duberstein wrote:
> As far as I can tell, this was never used.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Do you want me to take this and the other include fixups through the driver-core
tree or do you need them in rust-next as prerequisite for your CStr series?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: devres: remove unused import
  2025-07-04 20:23 ` Danilo Krummrich
@ 2025-07-04 20:30   ` Tamir Duberstein
  0 siblings, 0 replies; 4+ messages in thread
From: Tamir Duberstein @ 2025-07-04 20:30 UTC (permalink / raw)
  To: Danilo Krummrich
  Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Miguel Ojeda, Alex Gaynor,
	Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, rust-for-linux,
	linux-kernel

On Fri, Jul 4, 2025 at 4:23 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> On 7/4/25 10:11 PM, Tamir Duberstein wrote:
> > As far as I can tell, this was never used.
> >
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
>
> Do you want me to take this and the other include fixups through the driver-core
> tree or do you need them in rust-next as prerequisite for your CStr series?

If you can take them through the driver-core tree, that would be
great. They're needed for the CStr workstream but not for the first
(out of 5) cycle.

Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: devres: remove unused import
  2025-07-04 20:11 [PATCH] rust: devres: remove unused import Tamir Duberstein
  2025-07-04 20:23 ` Danilo Krummrich
@ 2025-07-05 15:12 ` Danilo Krummrich
  1 sibling, 0 replies; 4+ messages in thread
From: Danilo Krummrich @ 2025-07-05 15:12 UTC (permalink / raw)
  To: Tamir Duberstein
  Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Miguel Ojeda, Alex Gaynor,
	Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, rust-for-linux,
	linux-kernel

On Fri, Jul 04, 2025 at 04:11:02PM -0400, Tamir Duberstein wrote:
> As far as I can tell, this was never used.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Applied to driver-core-testing, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-05 15:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-04 20:11 [PATCH] rust: devres: remove unused import Tamir Duberstein
2025-07-04 20:23 ` Danilo Krummrich
2025-07-04 20:30   ` Tamir Duberstein
2025-07-05 15:12 ` Danilo Krummrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).