From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Siyuan Huang <huangsiyuan@kylinos.cn>
Cc: Len Brown <lenb@kernel.org>,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
dakr@kernel.org, linux-acpi@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: acpi: replace `core::mem::zeroed` with `pin_init::zeroed`
Date: Mon, 27 Oct 2025 20:30:33 +0100 [thread overview]
Message-ID: <CAJZ5v0gHK5_z25z0EdHVmkbpvMQqWdWObxUCFQt_S0bHV5LAQw@mail.gmail.com> (raw)
In-Reply-To: <CANiq72=9=W_j_o=oT+AdghQbEFbEmqT+Gx6q8oK8-yVwcrnDXQ@mail.gmail.com>
On Mon, Oct 20, 2025 at 1:26 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Mon, Oct 20, 2025 at 5:12 AM Siyuan Huang <huangsiyuan@kylinos.cn> wrote:
> >
> > All types in `bindings` implement `Zeroable` if they can, so use
> > `pin_init::zeroed` instead of relying on `unsafe` code.
> >
> > If this ends up not compiling in the future, something in bindgen or on
> > the C side changed and is most likely incorrect.
> >
> > Link: https://github.com/Rust-for-Linux/linux/issues/1189
> > Suggested-by: Benno Lossin <lossin@kernel.org>
> > Signed-off-by: Siyuan Huang <huangsiyuan@kylinos.cn>
>
> Rafael: I guess you will take this; otherwise, please let me know -- thanks!
Applied as 6.19 material, thanks!
next prev parent reply other threads:[~2025-10-27 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 3:12 [PATCH] rust: acpi: replace `core::mem::zeroed` with `pin_init::zeroed` Siyuan Huang
2025-10-20 8:18 ` Alice Ryhl
2025-10-20 13:11 ` Benno Lossin
2025-10-20 11:25 ` Miguel Ojeda
2025-10-27 19:30 ` Rafael J. Wysocki [this message]
2025-10-20 13:10 ` Benno Lossin
2025-10-20 13:17 ` Danilo Krummrich
2025-10-22 6:02 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gHK5_z25z0EdHVmkbpvMQqWdWObxUCFQt_S0bHV5LAQw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=huangsiyuan@kylinos.cn \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).