From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13A511398 for ; Sun, 23 Jul 2023 13:36:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3FE4C433CB; Sun, 23 Jul 2023 13:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690119362; bh=O1IIMN7Y1zRc3XOUmu8VPg3ACsmolQilL9wEXTaUfq0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bEohhuLUK1dSi12/IxXfSkxMEfJgOh0hOz+UucGXozkJpf7axqzuCpVb8Y+hXgCNX SaPf2jkC52Lm1mk0xAnT9v0MwB1AWeT1fEIov9y7rQUG4fEkIlmHDNVR5dhSzy5CU8 sXpyAm/oSnTJAtfE5yzVxKS0Jca0FEXYP2mYBl+HfuyM9gjsltwEXfbjtEIRJ2PiO4 BE8vBu94NSSU4v8qXxvtB/S72Bh16bAakamyFA35uOLtrZTy3Xp0Ai7vsgXS3ij2aj mx1S+a71fzn2Xa3D33cPycajyhSwu12mbW9UMKHoA4YbLhEUncOv1kBtnGCidfWSwA sQ/j/u+2oigow== Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3a36b52b4a4so2217932b6e.1; Sun, 23 Jul 2023 06:36:02 -0700 (PDT) X-Gm-Message-State: ABy/qLa0Y28e2mPMLHDyhmuWsYU8E0eEMyQvZmtmah9Udi2cc6+EK6Hw ucuLhpQ8w1O6DVVsywJ14Emb9FZZk6+0WHNK6Jc= X-Google-Smtp-Source: APBJJlEtZ7vv6IbOH84SATHMJCAMxnz2YpuXNOI1/BwoW86mbx9Nm47dGyoVL7wZ1gh1ODC5aHD1JS0QWO0h/EoEPu8= X-Received: by 2002:a05:6808:302c:b0:39c:7f78:ba6d with SMTP id ay44-20020a056808302c00b0039c7f78ba6dmr6412590oib.19.1690119361932; Sun, 23 Jul 2023 06:36:01 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230718055235.1050223-1-ojeda@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Sun, 23 Jul 2023 22:35:25 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: rust: avoid creating temporary files To: Miguel Ojeda Cc: Miguel Ojeda , Wedson Almeida Filho , Alex Gaynor , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Andreas Hindborg , linux-kbuild@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Raphael Nestler , Andrea Righi , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jul 23, 2023 at 2:05=E2=80=AFPM Masahiro Yamada wrote: > > On Sun, Jul 23, 2023 at 12:52=E2=80=AFAM Miguel Ojeda > wrote: > > > > On Thu, Jul 20, 2023 at 8:35=E2=80=AFPM Masahiro Yamada wrote: > > > > > > Maybe, the following was a breakage. > > > > > > commit 295d8398c67e314d99bb070f38883f83fe94a97a > > > Author: Masahiro Yamada > > > Date: Sat Jan 7 18:18:15 2023 +0900 > > > > > > kbuild: specify output names separately for each emission type fr= om rustc > > > > > > Before that, rust_common_cmd had --out-dir. > > > > That's right, good catch! > > > > > BTW, do we also need to fix scripts/Makefile.host > > > in case the external module Makefile creates host programs? > > > > Indeed, we need it too. [1] would fix it (tested it with a trivial > > out-of-tree Rust hostprog). > > > > Do you want me to send it separately? i.e. to avoid losing the > > `Tested-by`s etc. that we already got for this one, which is the > > important one since that actually has users. > > > > The hostprogs fix is not really critical for stable, since it is > > unlikely there are users at all (we just got the first in-tree real > > user in the Rust+KUnit integration coming into 6.6), but I guess it > > does not hurt for the same reason. > > > Can you send v2 with the following squashed? > > > I think it makes sense to fix both if we add > Fixes: 295d8398c67e ("kbuild: specify output names separately for each > emission type from rustc") I dropped v1 for now, expecting to get v2 soon. --=20 Best Regards Masahiro Yamada