From: Alistair Francis <alistair23@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
ojeda@kernel.org, boqun.feng@gmail.com, a.hindborg@kernel.org,
benno.lossin@proton.me, aliceryhl@google.com, tmgross@umich.edu,
gary@garyguo.net, Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] rust: bindings: Support some inline static functions
Date: Thu, 7 Nov 2024 12:26:43 +1000 [thread overview]
Message-ID: <CAKmqyKPv9DrvisrLOWX=i2qqKbRbNz40__FSGm6piC_0y94m_g@mail.gmail.com> (raw)
In-Reply-To: <CANiq72=L=CMUBu7jBn0H2Wb8vupYzOYFrSQ_9gyFZj_w2JU_uQ@mail.gmail.com>
On Tue, Nov 5, 2024 at 7:32 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Nov 5, 2024 at 3:22 AM Alistair Francis <alistair23@gmail.com> wrote:
> >
> > If this is accepted or at least Acked I can work on removing the
> > existing rust_helper_* functions and convert them to be auto-generated.
>
> Yeah, we have tracked the feature for a long time, please see:
>
> https://github.com/Rust-for-Linux/linux/issues/353
>
> So it is definitely in our plan to use (assuming it works).
>
> But, yeah, we would need the patch with the conversions, to show how
> it would look in practice (i.e. comparing before/after etc.), i.e. the
> usual kernel rule.
Great! I have done the conversions in a patch series here:
https://lore.kernel.org/lkml/20241107020831.1561063-1-alistair.francis@wdc.com/T/#t
>
> > + --allowlist-function crypto_shash_descsize
>
> We probably should put this into something similar to
> `rust/bindgen_parameters` (and remove this variable).
Fixed in https://lore.kernel.org/lkml/20241107020831.1561063-1-alistair.francis@wdc.com/T/#t
>
> > + @cp /tmp/bindgen/extern.c $(src)/
>
> I don't think we can use/assume `/tmp` -- we will need
> `--wrap-static-fns-path` or similar.
Fixed in https://lore.kernel.org/lkml/20241107020831.1561063-1-alistair.francis@wdc.com/T/#t
Alistair
>
> Thanks for trying out the new feature!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2024-11-07 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 2:21 [PATCH] rust: bindings: Support some inline static functions Alistair Francis
2024-11-05 9:31 ` Miguel Ojeda
2024-11-07 2:26 ` Alistair Francis [this message]
2024-11-06 0:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKPv9DrvisrLOWX=i2qqKbRbNz40__FSGm6piC_0y94m_g@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=alistair.francis@wdc.com \
--cc=benno.lossin@proton.me \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).