From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E391DDA0C for ; Thu, 17 Apr 2025 06:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744872818; cv=none; b=Tz51DyQVbFJ4ekHn985wHwAl8a540LPN4crx1iJhrF8L2HhDCLUNxXCp6vsicQq4KW/Cp6+RWcMqqG4nIOHbEhYBizY27ae8/JSviDCcYA/v/GapLIYQWutSBQNRXyNNd0/atHdQhAg3qJC4EsZmYcrlhxV1WbitsVwXftzgUUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744872818; c=relaxed/simple; bh=yfD1fdr0iWtPaImCVaMvQsmb3y3cZvCNHarqloDMNh4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=X8SE1HeS08+2EsCSE0S4Pu2lQ7T2OF/XGhl4Scm1MWp6IZTQEuYZvFVp0YoTI/SKY/0NkLvm+4Vp4ajvFxfYrUibCMGByna26xWd8r+vxaIbmKsRW5+YbXtlJbFG0B9agEerXLccvhes7bE9KirgX38k/ckKV2qhopsZPzRbXuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=umich.edu; spf=pass smtp.mailfrom=umich.edu; dkim=pass (2048-bit key) header.d=umich.edu header.i=@umich.edu header.b=cbzra9dF; arc=none smtp.client-ip=209.85.219.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=umich.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=umich.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=umich.edu header.i=@umich.edu header.b="cbzra9dF" Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-e728841ed96so126253276.3 for ; Wed, 16 Apr 2025 23:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; t=1744872816; x=1745477616; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rN6OekEdcAcx8JpVflYvmWKrrCmLr5pipCeXLvpFczY=; b=cbzra9dF6aRWA5MUUfaXX6Ojw+9J77ZDj6VpdvGI/a2rRL0olazYTQpT+fKKnl7qym F3kn/JGh/kUDW2odZj9K6KhcP0NygfY7+rHMKRlj+ynVfcu80fXZ8atwujG0iXzHzmr4 BBKHs9pSzCVjiuzks4pKb+c4GVSDv6DO7Zf4Om0d8emolY57Fo0k35+1MKk+C+cSHzir L2DI7VjCjnHN5gxhsgR8rOBgMPugQ6DNVymXPG55uuJt4G64P8qv0FSAmHg1P255Xn4r VigadZOrF/Qv5+Sjp/9B9q2L1sz7ZWrLnJ5Rvm1DofmkygA7QqCkpqMHlk8c09CEsjTi 33hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744872816; x=1745477616; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rN6OekEdcAcx8JpVflYvmWKrrCmLr5pipCeXLvpFczY=; b=R523xRY//1MTSbUZ79OO7xfOarr2GxtSMJkCrUeqoe2IP4muC77ykCS3l6xlE1rhiG hLFI9WjWAo2zxz81HpwW5XNR3NHfacpO51l4pGsWvD9LkyQHi0Vh6/j1j7sBDw6OFgYj SGn1LsSLgt3jw+5OOgElD0+d9Ub5jPcZFKjyzF38bWRtKYslfoHfWlK1hGCWvK1Z3Vol RUk5V+wGR6jfim2OmIYPfr/iPeRj3PAriyaqa/2CfXX6u8Z5lqXALCuFubOV7tfUTph9 kmY55pU21h1+zQuuQKT3dP5z9i4Nol9W1YGXiBRODFO0POWYqkRxE8e1Eg1m9m3osUm8 +XdA== X-Forwarded-Encrypted: i=1; AJvYcCVgjYAjPXZo2bqHNYzQb4RXDCZaHlUL/6jLp45xjYcg0rFaxQ1QjgT+bfeqFujJMHh78bDFxH2EqwvNhb1pRw==@vger.kernel.org X-Gm-Message-State: AOJu0YwVSqTA8kSKDjk7t2G0KOJSqefMoKf+T9djNFF3EyFCU6xw8rdp cl813sBat60+PZM9ZXa3XFJ7eP4sHw/2Sd+udY4Ie0VIqtKS5sZHouttdL9mPOAZxHYlJjF3ymc kj2vanix65Ni0XIJYxP2khAlJBB+QpmjSn1LOOg== X-Gm-Gg: ASbGncuTf4DsVrgAyTP7ew4Yx+9Q+vdFmh/9SjvyEUe6Nv/LhiJtW7JKJUGNBMrdp24 2C0ZgKeWlSv/AxW8JnkzS8lOjcoA4wd3qt+NAKP1lzpQnV2EyjMiUOA+NDb9Whw33VFyARTrg9m JFGJRdRySZoV6FpqIR9KGPBg== X-Google-Smtp-Source: AGHT+IH14VdsQvLLMXtXkv7oRvquwRgIOJr4HEstlMfsuTByjNPQvfn4TynHwhYN+MAZgKD8vCSfU2G136QJZh/42MI= X-Received: by 2002:a05:6902:2387:b0:e72:6ada:d0bb with SMTP id 3f1490d57ef6-e727574caadmr5706000276.4.1744872815795; Wed, 16 Apr 2025 23:53:35 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250325-rust-analyzer-host-v5-0-385e7f1e1e23@gmail.com> <20250325-rust-analyzer-host-v5-4-385e7f1e1e23@gmail.com> In-Reply-To: <20250325-rust-analyzer-host-v5-4-385e7f1e1e23@gmail.com> From: Trevor Gross Date: Thu, 17 Apr 2025 01:53:24 -0500 X-Gm-Features: ATxdqUEscG7iZyt3LnyOGWWKXBtuIM4kLb8N7cz8euqZP9UyPrmVQ7tK2A_pxkM Message-ID: Subject: Re: [PATCH v5 04/13] scripts: generate_rust_analyzer.py: extract `{build,register}_crate` To: Tamir Duberstein Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Danilo Krummrich , Boris-Chengbiao Zhou , Kees Cook , Fiona Behrens , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Wirth , Daniel Almeida Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 25, 2025 at 3:06=E2=80=AFPM Tamir Duberstein = wrote: > > Extract helpers from `append_crate` to avoid the need to peek into > `crates[-1]`. This improves readability. > > Suggested-by: Trevor Gross > Reviewed-by: Daniel Almeida > Tested-by: Daniel Almeida > Reviewed-by: Fiona Behrens > Signed-off-by: Tamir Duberstein > --- > scripts/generate_rust_analyzer.py | 35 ++++++++++++++++++++++++++++++---= -- > 1 file changed, 30 insertions(+), 5 deletions(-) Reviewed-by: Trevor Gross