From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 595683398B for ; Sun, 29 Sep 2024 04:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727584924; cv=none; b=NEwNRtqRcQVwDGvncNb+Zdr+P+suGiKmSk+LZLqEdrmKF5e6YAY4RpmzsyTL7yYr0m84UNbaFNVTB4VEd/9LJttQnR55Jj+JosupCYqJxyA73D8F1HMmoYh36uyGK2D1OHMb55RFRZfhfOuIn7bCe3ItvsNTR3FO2OQEMUO7A6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727584924; c=relaxed/simple; bh=vHzOMj9jD9kuxpfdw0bcPVwZ1W+/Pn85ztnlnrksZHk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=GeBh08DTQc39/xVvBWYKXe3WfVU4ZdKON+BOKmGTkwAKADJoMLWLEj+kEleXEe8kvN+oaNVsroGdkoxrr1LFHO5fFsg255bVwbWw477kh9bR44dGOewOTPz52iueElVrTgUdEYaEM12Ep53aaW5kKKgSMT165jjG1WjwK/rmrC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=umich.edu; spf=pass smtp.mailfrom=umich.edu; dkim=pass (2048-bit key) header.d=umich.edu header.i=@umich.edu header.b=jc5FU52a; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=umich.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=umich.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=umich.edu header.i=@umich.edu header.b="jc5FU52a" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-6e23aa29408so25915197b3.0 for ; Sat, 28 Sep 2024 21:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; t=1727584921; x=1728189721; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vHzOMj9jD9kuxpfdw0bcPVwZ1W+/Pn85ztnlnrksZHk=; b=jc5FU52aCdmNijUbU9BoYtNWXUYIGDUhfaTRy0Wfpv8mYOQimPL4rpZ0aN5NG/hlzr BczpzloZsLRoM/lw3O/vBIAO1h9AeGJJS0WyZHLSCov5rX69aLfNvRXJ2lX9vaIhe483 zkrOvmzLXXAbTaxQ2iS7p04J2KYybZt2oTcLhDX+jiY6nHiVRPxRVwjcDYo3ojciNP4M JULQHoprAdYKZg5RhDTsAb1qj/BvxUzl77FuVvYe+7WsVsWFoKNXfvaZhvnUj/N2JqsW wINX7x1WwPSQNUWkB0YjLlY5eLSewyAI0q/63Mw+Od3cDkqcV4kA9dZMzpcH/nIvLp1+ uOOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727584921; x=1728189721; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vHzOMj9jD9kuxpfdw0bcPVwZ1W+/Pn85ztnlnrksZHk=; b=fn8ZGxaB4g9OX3Ya5AWK6F6rGwnSi7aocHdxhOOVqTUBIrb2NGYq015N8r0AVRvJTS w3Oii01/WaXlXjTXTar/MnRrxGBXN+xm3ebYGBZT3fYzROS+DOtQlCTO8Li6kAZOrwZH LxKaKrV2RN6KzWmr7ivKx+kwdc+ME9MdNIxqqNfasHKjenWhyfRnbqm2UaN77Esn2I7Q LIW+U27zq0cgtE6zhntp0Fh5Vaakb3Rvxy1gS11Lr+Gq88DPRcea27nr9Riv+ule7UWG 6Au/XTpKuoKR5bYoqdBzKlA1zO6mWpmaSkGAenF/atMxS2kQC7xHFcPXjf2ETeY1Vn2+ iPTw== X-Forwarded-Encrypted: i=1; AJvYcCXHj0RcG6gob6IicLahue10tjFUUM86pt0btuj8Pd2dKdL1G1nP8Vhv4XNVWIXgLcxIb/szSRhkD6oJqI7+yg==@vger.kernel.org X-Gm-Message-State: AOJu0YxmwHqJVXli2NTziV20yoLUCGNYg2oIIBfJmaMXJwlX7dxNaxz9 vdNkeIIUmSkA0QSJC8S4QYI6M+K2go+GAJVefzqD9KLj+jzMX9wACgsby6KN+YL7vkawb9MJz7u c+MdTwLf/yjYMZCz1x8g00e3W7aibOcKnHZsFjg== X-Google-Smtp-Source: AGHT+IFvrDAqZx5NgF8LGfqkqSWrF6ZyKve0RQW2JLbiFzouK/e4QQP+LYMhrvl/TomKpgf5kQZo16BsN5iCCk3XejQ= X-Received: by 2002:a05:690c:700f:b0:6e2:2e8e:7a20 with SMTP id 00721157ae682-6e22edded73mr82279697b3.13.1727584920951; Sat, 28 Sep 2024 21:42:00 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240904204347.168520-1-ojeda@kernel.org> <20240904204347.168520-11-ojeda@kernel.org> In-Reply-To: <20240904204347.168520-11-ojeda@kernel.org> From: Trevor Gross Date: Sun, 29 Sep 2024 00:41:50 -0400 Message-ID: Subject: Re: [PATCH 10/19] rust: sync: remove unneeded `#[allow(clippy::non_send_fields_in_send_ty)]` To: Miguel Ojeda Cc: Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 4, 2024 at 4:45=E2=80=AFPM Miguel Ojeda wrot= e: > > Rust 1.58.0 (before Rust was merged into the kernel) made Clippy's > `non_send_fields_in_send_ty` lint part of the `suspicious` lint group for > a brief window of time [1] until the minor version 1.58.1 got released > a week after, where the lint was moved back to `nursery`. > > By that time, we had already upgraded to that Rust version, and thus we > had `allow`ed the lint here for `CondVar`. > > Nowadays, Clippy's `non_send_fields_in_send_ty` would still trigger here > if it were enabled. > > Moreover, if enabled, `Lock` and `Task` would also require an > `allow`. Therefore, it does not seem like someone is actually enabling it > (in, e.g., a custom flags build). > > Finally, the lint does not appear to have had major improvements since > then [2]. > > Thus remove the `allow` since it is unneeded. > > Link: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1= 581-2022-01-20 [1] > Link: https://github.com/rust-lang/rust-clippy/issues/8045 [2] > Signed-off-by: Miguel Ojeda Reviewed-by: Trevor Gross