From: Trevor Gross <tmgross@umich.edu>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
andrew@lunn.ch, miguel.ojeda.sandonis@gmail.com,
benno.lossin@proton.me, aliceryhl@google.com
Subject: Re: [PATCH net-next v5 4/6] rust: net::phy unified read/write API for C22 and C45 registers
Date: Mon, 19 Aug 2024 02:37:02 -0500 [thread overview]
Message-ID: <CALNs47tLDD2SQDeJ7h24Sakd6N244OXM8HvPsHQMds4XjwOTQw@mail.gmail.com> (raw)
In-Reply-To: <20240819005345.84255-5-fujita.tomonori@gmail.com>
On Sun, Aug 18, 2024 at 8:01 PM FUJITA Tomonori
<fujita.tomonori@gmail.com> wrote:
>
> Add the unified read/write API for C22 and C45 registers. The
> abstractions support access to only C22 registers now. Instead of
> adding read/write_c45 methods specifically for C45, a new reg module
> supports the unified API to access C22 and C45 registers with trait,
> by calling an appropriate phylib functions.
>
> Reviewed-by: Trevor Gross <tmgross@umich.edu>
> Reviewed-by: Benno Lossin <benno.lossin@proton.me>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> ---
If there winds up being another version, could you link the previous
chain for these two patches ([1]) in the cover letter? I knew it was
familiar but couldn't figure out where I had seen it before :)
[1]: https://lore.kernel.org/rust-for-linux/20240607052113.69026-1-fujita.tomonori@gmail.com/
next prev parent reply other threads:[~2024-08-19 7:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 0:53 [PATCH net-next v5 0/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-19 0:53 ` [PATCH net-next v5 1/6] rust: sizes: add commonly used constants FUJITA Tomonori
2024-08-19 5:54 ` Trevor Gross
2024-08-19 0:53 ` [PATCH net-next v5 2/6] rust: net::phy support probe callback FUJITA Tomonori
2024-08-19 7:10 ` Trevor Gross
2024-08-19 0:53 ` [PATCH net-next v5 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait FUJITA Tomonori
2024-08-19 7:21 ` Trevor Gross
2024-08-19 12:41 ` FUJITA Tomonori
2024-08-19 0:53 ` [PATCH net-next v5 4/6] rust: net::phy unified read/write API for C22 and C45 registers FUJITA Tomonori
2024-08-19 7:37 ` Trevor Gross [this message]
2024-08-19 12:41 ` FUJITA Tomonori
2024-08-19 0:53 ` [PATCH net-next v5 5/6] rust: net::phy unified genphy_read_status function " FUJITA Tomonori
2024-08-19 0:53 ` [PATCH net-next v5 6/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-19 9:07 ` Trevor Gross
2024-08-19 12:19 ` FUJITA Tomonori
2024-08-19 20:30 ` Trevor Gross
2024-08-19 22:46 ` Andrew Lunn
2024-08-20 1:07 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALNs47tLDD2SQDeJ7h24Sakd6N244OXM8HvPsHQMds4XjwOTQw@mail.gmail.com \
--to=tmgross@umich.edu \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=benno.lossin@proton.me \
--cc=fujita.tomonori@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).