Re: [RFC PATCH v2 3/3] net: phy: add Rust Asix PHY driver

[Trevor Gross <tmgross@umich.edu>]

On 9/24/23, FUJITA Tomonori <fujita.tomonori@gmail.com> wrote:

> +struct RustAsixPhy;
> +
> +impl RustAsixPhy {
> +    // Performs a software PHY reset using the standard
> +    // BMCR_RESET bit and poll for the reset bit to be cleared.
> +    // Toggle BMCR_RESET bit off to accommodate broken AX8796B PHY
> implementation
> +    // such as used on the Individual Computers' X-Surf 100 Zorro card.
> +    fn soft_reset(dev: &mut phy::Device) -> Result {
> +        dev.write(uapi::MII_BMCR as u16, 0)?;
> +        dev.genphy_soft_reset()
> +    }
> +}

I don't think there is any reason for this to be a type rather than
just a function?

    fn asix_soft_reset(dev: &mut phy::Device) -> Result {
        dev.write(uapi::MII_BMCR as u16, 0)?;
        dev.genphy_soft_reset()
    }

Also, we should make sure that the user-available MII_X constants are
available as a u16 rather than a c_int.

- Trevor