From: Trevor Gross <tmgross@umich.edu>
To: Michal Rostecki <vadorovsky@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"Finn Behrens" <me@kloenk.dev>,
"Manmohan Shukla" <manmshuk@gmail.com>,
"Valentin Obst" <kernel@valentinobst.de>,
"Yutaro Ohno" <yutaro.ono.418@gmail.com>,
"Asahi Lina" <lina@asahilina.net>,
"Danilo Krummrich" <dakr@redhat.com>,
"Tiago Lam" <tiagolam@gmail.com>,
"Charalampos Mitrodimas" <charmitro@posteo.net>,
"Tejun Heo" <tj@kernel.org>, "Roland Xu" <mu001999@outlook.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
netdev@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH RESEND v5] rust: str: Use `core::CStr`, remove the custom `CStr` implementation
Date: Sat, 24 Aug 2024 02:24:50 -0500 [thread overview]
Message-ID: <CALNs47uKWTH9mUhEp1-f=zX8fgPpWExQWct0YYa2Q9H6yuaKJA@mail.gmail.com> (raw)
In-Reply-To: <36272d4a-eb95-4842-b171-ad6ec39a7631@gmail.com>
On Mon, Aug 19, 2024 at 10:43 AM Michal Rostecki <vadorovsky@gmail.com> wrote:
>
> On 8/19/24 17:36, Michal Rostecki wrote:
> > From: Michal Rostecki <vadorovsky@gmail.com>
> >
> > `CStr` became a part of `core` library in Rust 1.75. This change replaces
> > the custom `CStr` implementation with the one from `core`.
[ very long snip ]
> > @@ -180,7 +180,7 @@ macro_rules! assert {{
> > #[allow(unused)]
> > macro_rules! assert_eq {{
> > ($left:expr, $right:expr $(,)?) => {{{{
> > - kernel::kunit_assert_eq!("{kunit_name}", "{real_path}", __DOCTEST_ANCHOR - {line}, $left, $right);
> > + kernel::kunit_assert_eq!(c"{kunit_name}", c"{real_path}", __DOCTEST_ANCHOR - {line}, $left, $right);
> > }}}}
> > }}
> >
>
> I forgot to include the version history before sending the patch, sorry.
For future reference - when replying, you should delete irrelevant
bits of the message you are replying to, otherwise things get kind of
messy.
- Trevor
next prev parent reply other threads:[~2024-08-24 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 15:36 [PATCH RESEND v5] rust: str: Use `core::CStr`, remove the custom `CStr` implementation Michal Rostecki
2024-08-19 15:41 ` Michal Rostecki
2024-08-24 7:24 ` Trevor Gross [this message]
2024-08-21 12:08 ` Alice Ryhl
2024-08-21 13:47 ` Alice Ryhl
2024-08-21 19:07 ` Benno Lossin
2024-08-24 7:22 ` Trevor Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALNs47uKWTH9mUhEp1-f=zX8fgPpWExQWct0YYa2Q9H6yuaKJA@mail.gmail.com' \
--to=tmgross@umich.edu \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=charmitro@posteo.net \
--cc=dakr@redhat.com \
--cc=davidgow@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=kunit-dev@googlegroups.com \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=manmshuk@gmail.com \
--cc=me@kloenk.dev \
--cc=morbo@google.com \
--cc=mu001999@outlook.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rmoar@google.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tiagolam@gmail.com \
--cc=tj@kernel.org \
--cc=vadorovsky@gmail.com \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
--cc=yutaro.ono.418@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).