From: Trevor Gross <tmgross@umich.edu>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: rust-for-linux@vger.kernel.org, David Gow <davidgow@google.com>,
Alice Ryhl <aliceryhl@google.com>,
Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH v4 2/2] docs: rust: Add description of Rust documentation test as KUnit ones
Date: Wed, 31 Jan 2024 21:05:38 -0500 [thread overview]
Message-ID: <CALNs47vHCYeR4kPiY4985_EyfebNOr=ZO36JvAHd5h5E=yGcbA@mail.gmail.com> (raw)
In-Reply-To: <20240130075117.4137360-2-dirk.behme@de.bosch.com>
On Tue, Jan 30, 2024 at 2:51 AM Dirk Behme <dirk.behme@de.bosch.com> wrote:
>
> Rust documentation tests are automatically converted into KUnit
> tests. The commit adding this feature
>
> commit a66d733da801 ("rust: support running Rust documentation tests as KUnit ones")
>
> from Miguel has a very nice commit message with a lot details
> for this. To not 'hide' that just in a commit message, pick the main
> parts of it and add it to the documentation. And add a short info
> how to enable this. While adding this, improve the structure of
> the sections.
>
> Reviewed-by: David Gow <davidgow@google.com>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Co-developed-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> ---
This looks good to me, thanks for the improvement.
Reviewed-by: Trevor Gross <tmgross@umich.edu>
next prev parent reply other threads:[~2024-02-01 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 7:51 [PATCH v4 1/2] docs: rust: Move testing to a separate page Dirk Behme
2024-01-30 7:51 ` [PATCH v4 2/2] docs: rust: Add description of Rust documentation test as KUnit ones Dirk Behme
2024-02-01 2:05 ` Trevor Gross [this message]
2024-02-18 20:23 ` [PATCH v4 1/2] docs: rust: Move testing to a separate page Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALNs47vHCYeR4kPiY4985_EyfebNOr=ZO36JvAHd5h5E=yGcbA@mail.gmail.com' \
--to=tmgross@umich.edu \
--cc=aliceryhl@google.com \
--cc=davidgow@google.com \
--cc=dirk.behme@de.bosch.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).