rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trevor Gross <tmgross@umich.edu>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: rust-for-linux@vger.kernel.org, andrew@lunn.ch, benno.lossin@proton.me
Subject: Re: [RFC PATCH v4 1/2] rust: net::phy unified read/write API for C22 and C45 registers
Date: Thu, 13 Jun 2024 12:59:52 -0500	[thread overview]
Message-ID: <CALNs47vVU-rD99zrGPT2DG9BsAEwQdjVwaBfFx-268TbsEc3rg@mail.gmail.com> (raw)
In-Reply-To: <20240607052113.69026-2-fujita.tomonori@gmail.com>

On Fri, Jun 7, 2024 at 12:22 AM FUJITA Tomonori
<fujita.tomonori@gmail.com> wrote:
>
> Add the unified read/write API for C22 and C45 registers. The
> abstractions support access to only C22 registers now. Instead of
> adding read/write_c45 methods specifically for C45, a new reg module
> supports the unified API to access C22 and C45 registers with trait,
> by calling an appropriate phylib functions.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>

This new API looks good to me:

Reviewed-by: Trevor Gross <tmgross@umich.edu>

It should probably also get Benno's review since he suggested the API.

  reply	other threads:[~2024-06-13 18:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  5:21 [RFC PATCH v4 0/2] net::phy add unified API for C22 and C45 registers FUJITA Tomonori
2024-06-07  5:21 ` [RFC PATCH v4 1/2] rust: net::phy unified read/write " FUJITA Tomonori
2024-06-13 17:59   ` Trevor Gross [this message]
2024-06-13 23:32     ` FUJITA Tomonori
2024-06-14  8:30       ` Benno Lossin
2024-06-14  9:57         ` FUJITA Tomonori
2024-06-07  5:21 ` [RFC PATCH v4 2/2] rust: net::phy unified genphy_read_status function " FUJITA Tomonori
2024-06-13 18:00   ` Trevor Gross
2024-06-14 12:53 ` [RFC PATCH v4 0/2] net::phy add unified API " Benno Lossin
2024-06-15  7:39   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALNs47vVU-rD99zrGPT2DG9BsAEwQdjVwaBfFx-268TbsEc3rg@mail.gmail.com \
    --to=tmgross@umich.edu \
    --cc=andrew@lunn.ch \
    --cc=benno.lossin@proton.me \
    --cc=fujita.tomonori@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).