From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1361D2F57 for ; Tue, 27 Aug 2024 19:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724785880; cv=none; b=GSPo3Jz2Q37imDWw8x2BS0c+jdaiaYtYH2ZdWXMDeBYlJVgXZZLCvH+5NJU+oi/XSkqyNaqSLsolgHz/lwtesICUquLjVzhFpHf+egfzXbzR6Jgtz1VI4Zn1y727Xmb/pCa8+S9a4HAm7i67ErDMGzaz6ljwnM2FmQVv305di9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724785880; c=relaxed/simple; bh=xNzO7qOTTQGEuyADmXVfFcDNzsBtnhXqp36UzvFFVE0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Up89ymdp2ceW3TO+uq9gbQN0oUIfiYqNbyOmEOY7ap5cr+Nr0i7at7SG7Tlg1znSoVHMj4c+HpLz8Ha6EFXEBbL0GJ+4Wq4NJB/XJhRL1HZZ9J8rM5MwZDPRBnYkNjhIGVD21rgN1SLVlnYVoaSLj9jwB2qpsAPwENmWnrVQqHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=umich.edu; spf=pass smtp.mailfrom=umich.edu; dkim=pass (2048-bit key) header.d=umich.edu header.i=@umich.edu header.b=p7gFyxcz; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=umich.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=umich.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=umich.edu header.i=@umich.edu header.b="p7gFyxcz" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6b3afc6cd01so53734307b3.1 for ; Tue, 27 Aug 2024 12:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; t=1724785877; x=1725390677; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xNzO7qOTTQGEuyADmXVfFcDNzsBtnhXqp36UzvFFVE0=; b=p7gFyxczx+7zdP7P/+Rh7k8h/euUbWV/c6+j94luI2EhyrKbsbIVMNQoNP194VOLBm Udh1t2zSHqe/O6UDjd+umMikLrT9CcZrnDEiUtotjtKuh3mtwc5afrvY2x3hQ4mYUyzE OE+dL4j4q8pDXdXc1rTMGDR/BMn8MGk0iVlTFfDy+4aVAd1F85zP7oxwkP1wZJqknf2L W2t1+udeA15Hs07xj1K9NTMYP1eveTJu1iEq5p8dKr+JYJLlFe9LlT4DEQsapdskM2UH xKn8GVO13IVL7Bm1FaACmftOfKgslhKXW2fWYMpENaGRJXh8MIcB8YJEmrGgtv252H1d pvNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724785877; x=1725390677; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xNzO7qOTTQGEuyADmXVfFcDNzsBtnhXqp36UzvFFVE0=; b=uNr5m7V+Zv0plqn8M+FSY627uDtvB3m2XiXzPFDfu9GyiL/Kbv4XQfqmDclk98JLyv CgnKkDIQegrmryNn9qK7ZF5J91VLurH9tis2VU95qR42Vb6juO6boHQXu9JBP5HVeQVb 4vnMRPir79zWbCXfJuhR6Pj0YjEyeyFZ+jrNLX92vWWrimmFQMcrgLR+BhmPS7x6Vyz0 KOX0fca6mj6Z5LthyHSfapCpOvb22iNK+aDaiY/s0HNol06Iah5U4BCdH6HkYVNWFgWD mBEJtHfEtw1AaIGYh7UXgalE6k9ys98HnAtTIOe+U8z68GRsqGC8kIk6UQks9WfL48Wo eC3A== X-Forwarded-Encrypted: i=1; AJvYcCWeMkK6/z0V/lo61mRjbpSosnrAyU1yiOBn9Pla7zQPbrUqSvavWQHWxjJAzvt8gUUdwO/gIUGqE+DeCZi81w==@vger.kernel.org X-Gm-Message-State: AOJu0YxfpWItBWZ6KBoWlHETTMMMztXxKoEAFIXsYr8mnj717rZ10eWt vvWurqp46GPkjLPhR6e73QCqFy72ule5gqJCOauT0wutw0HnNt8QQ4AcNNTXrb9r18MlORQHwvs s8/aJ6yffMlvvYcHmJdCRE64s8YqeRARqATJuLA== X-Google-Smtp-Source: AGHT+IFvAuIzn1nxkt/URa8Wh42r+pnypqpU85+ebAjYMRQV9X8DnUpctjW9fn8HkMEtDjJXr7rc4KN16ZG+0YDepro= X-Received: by 2002:a05:690c:6a89:b0:622:c892:6ae7 with SMTP id 00721157ae682-6d129dbf29emr2279337b3.12.1724785877378; Tue, 27 Aug 2024 12:11:17 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240819133345.3438739-1-nmi@metaspace.dk> <875xrmxdzg.fsf@metaspace.dk> In-Reply-To: <875xrmxdzg.fsf@metaspace.dk> From: Trevor Gross Date: Tue, 27 Aug 2024 15:11:05 -0400 Message-ID: Subject: Re: [PATCH v2] rust: add `module_params` macro To: Andreas Hindborg Cc: Luis Chamberlain , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Andreas Hindborg , Adam Bratschi-Kaye , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Daniel Gomez , rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 27, 2024 at 10:00=E2=80=AFAM Andreas Hindborg wrote: > > "Trevor Gross" writes: > > > On Mon, Aug 19, 2024 at 8:35=E2=80=AFAM Andreas Hindborg wrote: > >> > >> From: Andreas Hindborg > >> > >> This patch includes changes required for Rust kernel modules to utiliz= e > >> module parameters. This code implements read only support for integer > >> types without `sysfs` support. > > > > Also, I think the subject line needs an update ("rust: add > > `module_params` macro") > > Well, it is still what it does. Plus few support types. You think it is > not descriptive enough? Maybe it should just say 'Add parameter support to the `module!` macro'? The text `module_params` doesn't seem to appear in the patch, I was looking for something like `module_params!`. - Trevor > BR Andreas