From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Asahi Lina" <lina@asahilina.net>
Subject: Re: [PATCH 2/2] rust: drm: Add GPUVM abstraction
Date: Mon, 24 Mar 2025 22:07:10 +0100 [thread overview]
Message-ID: <CANiq72=4+ubh0F5y2QMobFoyQPs4Aj7bOL8n4y9LzHxrb9Z2sQ@mail.gmail.com> (raw)
In-Reply-To: <CANiq72=aVRMvOaU48DBLL=p+VoG3RvHK+K48XQhvHw3ARc0BNg@mail.gmail.com>
On Mon, Mar 24, 2025 at 8:38 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> Yeah, I asked upstream if we could have something that at least
> detects what could have been intra-doc links, because that should not
> have too many false positives since it is a subset:
>
> https://github.com/rust-lang/rust/issues/131510
>
> It is still tricky, because e.g. `Some` or `None` would need to be
> excluded, even if you require the exact same case. So it probably
> still requires extra heuristics.
>
> Then there is:
>
> https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
>
> which is closer to your idea. It has a few false positives (e.g.
> KUnit) from a quick try, so probably we cannot enable it for
> everything, unless we commit to maintain a list of terms in the
> config. It spots a handful of things we should fix, though -- I can
> send a few patches or create good first issues.
I went ahead and sent a quick series for the latter:
https://lore.kernel.org/rust-for-linux/20250324210359.1199574-1-ojeda@kernel.org/
Cheers,
Miguel
next prev parent reply other threads:[~2025-03-24 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 15:13 [PATCH 0/2] Add a Rust GPUVM abstraction Daniel Almeida
2025-03-24 15:13 ` [PATCH 1/2] rust: helpers: Add bindings/wrappers for dma_resv Daniel Almeida
2025-03-24 18:43 ` Miguel Ojeda
2025-03-24 15:13 ` [PATCH 2/2] rust: drm: Add GPUVM abstraction Daniel Almeida
2025-03-24 17:36 ` Miguel Ojeda
2025-03-24 19:25 ` Daniel Almeida
2025-03-24 19:38 ` Miguel Ojeda
2025-03-24 21:07 ` Miguel Ojeda [this message]
2025-03-24 20:22 ` Benno Lossin
2025-03-24 18:29 ` Charalampos Mitrodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=4+ubh0F5y2QMobFoyQPs4Aj7bOL8n4y9LzHxrb9Z2sQ@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).