From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Asuna Yang <spriteovo@gmail.com>
Cc: "Conor Dooley" <conor@kernel.org>,
"Jason Montleon" <jmontleo@redhat.com>,
"Han Gao" <rabenda.cn@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Tejun Heo" <tj@kernel.org>, "Kees Cook" <kees@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Matthew Maurer" <mmaurer@google.com>,
"Jeff Xu" <jeffxu@chromium.org>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Jan Hendrik Farr" <kernel@jfarr.cc>,
"Michal Koutný" <mkoutny@suse.com>,
"Christian Brauner" <brauner@kernel.org>,
"Brian Gerst" <brgerst@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev,
rust-for-linux <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 2/2] RISC-V: re-enable gcc + rust builds
Date: Thu, 4 Sep 2025 01:27:03 +0200 [thread overview]
Message-ID: <CANiq72=FJSRwOPNG4ZFeoex3MssTjmhozp5Xd++PTCCSJaJ3hA@mail.gmail.com> (raw)
In-Reply-To: <20250903190806.2604757-2-SpriteOvO@gmail.com>
On Wed, Sep 3, 2025 at 9:08 PM Asuna Yang <spriteovo@gmail.com> wrote:
>
> Commit 33549fcf37ec ("RISC-V: disallow gcc + rust builds") disabled GCC
> + Rust builds for RISC-V due to differences in extension handling
> compared to LLVM.
>
> Add a Kconfig non-visible symbol to ensure that all important RISC-V
> specific flags that will be used by GCC can be correctly recognized by
> Rust bindgen's libclang, otherwise config HAVE_RUST will not be
> selected.
I think the commit message should try to explain each the changes here
(or to split them).
e.g. it doesn't mention the other config symbols added, nor the extra
flag skipped, nor the `error` call.
Cc'ing the rust-for-linux list.
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2025-09-03 23:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 5:00 RISC-V: Re-enable GCC+Rust builds Asuna Yang
2025-08-30 18:17 ` Conor Dooley
2025-09-01 14:08 ` Conor Dooley
2025-09-01 17:19 ` Asuna
2025-09-01 18:04 ` Conor Dooley
2025-09-03 0:59 ` Asuna
2025-09-04 11:28 ` Conor Dooley
2025-09-03 18:52 ` Asuna
[not found] ` <20250903190806.2604757-1-SpriteOvO@gmail.com>
2025-09-03 23:24 ` [PATCH 1/2] rust: get the version of libclang used by bindgen in a separate script Miguel Ojeda
2025-09-04 23:15 ` Asuna
[not found] ` <20250903190806.2604757-2-SpriteOvO@gmail.com>
2025-09-03 23:27 ` Miguel Ojeda [this message]
2025-09-04 23:17 ` [PATCH 2/2] RISC-V: re-enable gcc + rust builds Asuna
[not found] ` <20250904-sterilize-swagger-c7999b124e83@spud>
[not found] ` <f7434b76-49d0-4ef3-8c77-c1642dc211cd@gmail.com>
2025-09-04 23:07 ` Asuna
2025-09-05 15:25 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=FJSRwOPNG4ZFeoex3MssTjmhozp5Xd++PTCCSJaJ3hA@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=brgerst@gmail.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jeffxu@chromium.org \
--cc=jmontleo@redhat.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kernel@jfarr.cc \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=masahiroy@kernel.org \
--cc=mkoutny@suse.com \
--cc=mmaurer@google.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=rabenda.cn@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=spriteovo@gmail.com \
--cc=tj@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).