* [PATCH] rust: helpers: sort includes alphabetically
@ 2025-06-29 15:10 krikera
0 siblings, 0 replies; 4+ messages in thread
From: krikera @ 2025-06-29 15:10 UTC (permalink / raw)
To: rust-for-linux, linux-kernel
Cc: ojeda, alex.gaynor, boqun.feng, gary, bjorn3_gh, lossin,
a.hindborg, aliceryhl, tmgross, dakr, krikera
The helper includes should be sorted alphabetically as indicated by the
comment at the top of the file, but they were not. Sort them properly.
Suggested-by: Alice Ryhl <aliceryhl@google.com>
Link: https://github.com/Rust-for-Linux/linux/issues/1174
Signed-off-by: krikera <prafulrai522@gmail.com>
---
rust/helpers/helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
index b15b3cddad4e..d3867d09e356 100644
--- a/rust/helpers/helpers.c
+++ b/rust/helpers/helpers.c
@@ -29,9 +29,9 @@
#include "mm.c"
#include "mutex.c"
#include "page.c"
-#include "platform.c"
#include "pci.c"
#include "pid_namespace.c"
+#include "platform.c"
#include "rbtree.c"
#include "rcu.c"
#include "refcount.c"
--
2.41.0.windows.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: helpers: sort includes alphabetically
[not found] <CAJLqYhqwyX36mV3kpkcMkGB7_giE-kugfVVt=duWOVJyGbNDkA@mail.gmail.com>
@ 2025-06-29 15:13 ` Miguel Ojeda
0 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2025-06-29 15:13 UTC (permalink / raw)
To: Krikera
Cc: rust-for-linux, linux-kernel, ojeda, alex.gaynor, boqun.feng,
gary, bjorn3_gh, lossin, a.hindborg, aliceryhl, tmgross, dakr
On Sun, Jun 29, 2025 at 4:28 PM Krikera <prafulrai522@gmail.com> wrote:
>
> Signed-off-by: krikera <prafulrai522@gmail.com>
Thanks for the patch!
Is krikera a "known identity" according to the DCO?
https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] rust: helpers: sort includes alphabetically
@ 2025-06-29 15:25 Krishna Ketan Rai
2025-07-14 23:31 ` Miguel Ojeda
0 siblings, 1 reply; 4+ messages in thread
From: Krishna Ketan Rai @ 2025-06-29 15:25 UTC (permalink / raw)
To: rust-for-linux, linux-kernel
Cc: ojeda, alex.gaynor, boqun.feng, gary, bjorn3_gh, lossin,
a.hindborg, aliceryhl, tmgross, dakr, Krishna Ketan Rai
The helper includes should be sorted alphabetically as indicated by the
comment at the top of the file, but they were not. Sort them properly.
Suggested-by: Alice Ryhl <aliceryhl@google.com>
Link: https://github.com/Rust-for-Linux/linux/issues/1174
Signed-off-by: Krishna Ketan Rai <prafulrai522@gmail.com>
---
rust/helpers/helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
index b15b3cddad4e..d3867d09e356 100644
--- a/rust/helpers/helpers.c
+++ b/rust/helpers/helpers.c
@@ -29,9 +29,9 @@
#include "mm.c"
#include "mutex.c"
#include "page.c"
-#include "platform.c"
#include "pci.c"
#include "pid_namespace.c"
+#include "platform.c"
#include "rbtree.c"
#include "rcu.c"
#include "refcount.c"
--
2.41.0.windows.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: helpers: sort includes alphabetically
2025-06-29 15:25 [PATCH] rust: helpers: sort includes alphabetically Krishna Ketan Rai
@ 2025-07-14 23:31 ` Miguel Ojeda
0 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2025-07-14 23:31 UTC (permalink / raw)
To: Krishna Ketan Rai
Cc: rust-for-linux, linux-kernel, ojeda, alex.gaynor, boqun.feng,
gary, bjorn3_gh, lossin, a.hindborg, aliceryhl, tmgross, dakr
On Sun, Jun 29, 2025 at 5:26 PM Krishna Ketan Rai
<prafulrai522@gmail.com> wrote:
>
> The helper includes should be sorted alphabetically as indicated by the
> comment at the top of the file, but they were not. Sort them properly.
>
> Suggested-by: Alice Ryhl <aliceryhl@google.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/1174
> Signed-off-by: Krishna Ketan Rai <prafulrai522@gmail.com>
Applied to `rust-next` -- thanks everyone!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-14 23:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-29 15:25 [PATCH] rust: helpers: sort includes alphabetically Krishna Ketan Rai
2025-07-14 23:31 ` Miguel Ojeda
[not found] <CAJLqYhqwyX36mV3kpkcMkGB7_giE-kugfVVt=duWOVJyGbNDkA@mail.gmail.com>
2025-06-29 15:13 ` Miguel Ojeda
-- strict thread matches above, loose matches on Subject: below --
2025-06-29 15:10 krikera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).