rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Guilherme Augusto Martins da Silva <guilhermev2huehue@gmail.com>,
	Daniel Sedlak <daniel@sedlak.dev>
Cc: rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust-next: make from_errno use try_from_errno
Date: Mon, 4 Nov 2024 21:14:59 +0100	[thread overview]
Message-ID: <CANiq72=fcjmDqqYT+wLKNr1qQRgcomaBcaedUxzLXmiLvU5hrQ@mail.gmail.com> (raw)
In-Reply-To: <20241104200014.12996-1-guilhermev2huehue@gmail.com>

Hi Guilherme, Daniel,

On Mon, Nov 4, 2024 at 9:01 PM Guilherme Augusto Martins da Silva
<guilhermev2huehue@gmail.com> wrote:
>
> Make from_errno use try_from_errno (available in rust-next).

Normally you would note the "available in rust-next" part in the
non-commit part (i.e. below the `---` line).

>  this project or the open source license(s) involved.

Spurious line from the previous Developer's Certificate of Origin you
had in the commit message (in private).

> Signed-off-by: Guilherme Augusto Martins da Silva <guilhermev2huehue@gmail.com>

Please add the Suggested-by and the Link tags as mentioned in the issue.

So I got these two at essentially the same time, but Guilherme's in
private, as we discussed.

I think you should both be co-authors, although you will need to
decide who will be the main author and send a v2 merging both patches
into the best version possible :)

Please see my notes in the other one too.

Cheers,
Miguel

  reply	other threads:[~2024-11-04 20:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 20:00 [PATCH] rust-next: make from_errno use try_from_errno Guilherme Augusto Martins da Silva
2024-11-04 20:14 ` Miguel Ojeda [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-05 11:48 Guilherme Augusto Martins da Silva
2024-11-07 12:26 ` Rasmus Villemoes
2024-11-14 19:42 ` Daniel Sedlak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72=fcjmDqqYT+wLKNr1qQRgcomaBcaedUxzLXmiLvU5hrQ@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=daniel@sedlak.dev \
    --cc=guilhermev2huehue@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).