From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: irq: add support for request_irq()
Date: Thu, 24 Oct 2024 17:05:30 +0200 [thread overview]
Message-ID: <CANiq72=tywaM4n-6isLmpu5fC3uj5H7g4QfiaksXcaPH_Pfxaw@mail.gmail.com> (raw)
In-Reply-To: <20241024-topic-panthor-rs-request_irq-v1-1-7cbc51c182ca@collabora.com>
Hi Daniel,
A couple procedural things on your latest patches (no need to send new
versions right away).
On Thu, Oct 24, 2024 at 4:20 PM Daniel Almeida
<daniel.almeida@collabora.com> wrote:
>
> Both regular and threaded versions are supported.
I am not sure if the commit message was truncated, but it should
explain why the change is done and what is being changed. For
instance, it should mention who will need this upstream. Please see
other similar patches/series we have, e.g. one of the latest ones in Lore:
https://lore.kernel.org/rust-for-linux/20241022213221.2383-1-dakr@kernel.org/
> base-commit: 33c255312660653cf54f8019896b5dca28e3c580
Please try this one on top of `rust-next` -- you will get new Clippy
warnings about missing safety sections & comments.
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2024-10-24 15:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 14:20 [PATCH] rust: irq: add support for request_irq() Daniel Almeida
2024-10-24 15:05 ` Miguel Ojeda [this message]
2024-10-24 15:08 ` Daniel Almeida
2024-10-27 5:30 ` kernel test robot
2024-10-28 15:29 ` Alice Ryhl
2024-11-04 20:10 ` Daniel Almeida
2024-11-06 11:17 ` Alice Ryhl
2024-10-29 11:59 ` Alice Ryhl
2024-11-04 19:19 ` Daniel Almeida
2025-01-13 14:42 ` Alice Ryhl
2025-01-14 18:34 ` Daniel Almeida
2025-01-14 18:36 ` Alice Ryhl
2025-01-14 18:57 ` Daniel Almeida
2025-01-15 0:45 ` Boqun Feng
2025-01-15 8:27 ` Alice Ryhl
2025-01-15 14:39 ` Boqun Feng
2025-01-15 14:42 ` Alice Ryhl
2025-01-15 16:00 ` Boqun Feng
2025-01-15 15:37 ` Daniel Almeida
2025-01-15 11:38 ` Gary Guo
2025-01-15 12:31 ` Daniel Almeida
2025-01-16 8:29 ` Alice Ryhl
2025-01-19 17:50 ` Boqun Feng
2025-01-15 11:42 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=tywaM4n-6isLmpu5fC3uj5H7g4QfiaksXcaPH_Pfxaw@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).