From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Gary Guo <gary@garyguo.net>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>,
"Wedson Almeida Filho" <walmeida@microsoft.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: bindings: rename const binding using sed
Date: Wed, 13 Dec 2023 19:44:10 +0100 [thread overview]
Message-ID: <CANiq72k46_1gnEMnB-38N45yOwnKFFLkwZbgB7taYppT2jPAnQ@mail.gmail.com> (raw)
In-Reply-To: <20231104145700.2495176-1-gary@garyguo.net>
On Sat, Nov 4, 2023 at 3:58 PM Gary Guo <gary@garyguo.net> wrote:
>
> This patch changes the way we define constant helpers to
>
> const <TYPE> RUST_CONST_HELPER_<NAME> = <NAME>;
>
> and then use `sed` to postprocess Rust code by generated by bindgen to
> remove the distinct prefix, so user of the binding crate can refer to
> the name directly.
>
> Reviewed-by: Benno Lossin <benno.lossin@proton.me>
> Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com>
> Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
> Signed-off-by: Gary Guo <gary@garyguo.net>
Applied to `rust-next` (reworded for typos and with Benno's `^`
suggestion -- we can always relax it back later if needed, the output
is currently the same).
Thanks everyone!
Cheers,
Miguel
next prev parent reply other threads:[~2023-12-13 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 14:56 [PATCH v2] rust: bindings: rename const binding using sed Gary Guo
2023-11-05 11:03 ` Alice Ryhl
2023-11-06 22:16 ` Benno Lossin
2023-12-13 18:44 ` Miguel Ojeda [this message]
2023-12-14 19:21 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72k46_1gnEMnB-38N45yOwnKFFLkwZbgB7taYppT2jPAnQ@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=vincenzopalazzodev@gmail.com \
--cc=walmeida@microsoft.com \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).