From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UV1JTqmq" Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E83E6DC; Wed, 13 Dec 2023 10:44:21 -0800 (PST) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-dbcd28d5004so894652276.1; Wed, 13 Dec 2023 10:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702493061; x=1703097861; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2G6kj7N4hRgNEBr/3B4wFHKE0y6pfp8gXRui9/NHf1s=; b=UV1JTqmqlOr4+4W3DCh4Z6LY3Pwi4x0o+J/Qp8dXGjmm8KZjsXUImlnkwl7S2+mnoB A3mRvSvlNz0XUT9LZycAbt13bz0+9fj7pGbbUzhmm+wpZTG4N9HoWbt2N2/AI46V1Ema d5lXnArSVNI4Tlz4S+RKOeZTnYN0nM/Pbl0NBHuXW+agnboGkUZHS/OQC2LMMlKf21ZS 7Gse6D4KsAsnCUQQgaVgT8TmjJVcLyyefSuNkGXlt5l0sQCUJo4qToSZQLQApWb2c3zn O7gq23weCBWvh4hFYKdSt01630TmsWO2gIefiamClnUeDR6U/eIak4i6Cp0RGyV2juPR y+6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702493061; x=1703097861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2G6kj7N4hRgNEBr/3B4wFHKE0y6pfp8gXRui9/NHf1s=; b=bf0h4H6xG3SQVR1F6Zdo3wCKmL0mozV4QZHpOAoMw8qdrCquE72mnYXx0XstpjKeU3 Rr/cjJZey5AVxfKc5yEG3nUf8FgHzYfV1FEbgRXV5yjPLbc+gFhdj8sAA+8kEXOtpuwd hRYRinR6hoBa7onEdTjZXb/uGNPHM3ztQ/LAGTSLDiH7vPhk/HTnSCzBHxtpC6f2TnBH vZ2FEA2T5hh0JLYxRgK+t9ZVPcDL7OpUQhfsAQf1mbxJfNOSMwqjJAvNhirKwPXeRjoQ FnBPsJkd8vKkaSLWA0/O71SJobJz7K6VrJfdWtFkjEBXzlF/T74DrYBkNByvI87jx4bb 0Tgw== X-Gm-Message-State: AOJu0Yx8d9/dC/YDkXgiFqu+JmXBlRHCnNY0EL+cbOJzoSb3UvW7ON0d ZWveiqD9v2Y/zT7SItnZbZLXZzxhJ4gMqqN3K94= X-Google-Smtp-Source: AGHT+IG003CwX1sQ2R1egd8LKs25wIsiZ/fBxYPmfOwQLvYxUacCLiVnULMyy5nYe8A/Cu0X6mMbg9VAmmQ1QS/HUgY= X-Received: by 2002:a25:2905:0:b0:dbc:66c0:574c with SMTP id p5-20020a252905000000b00dbc66c0574cmr5369399ybp.127.1702493061092; Wed, 13 Dec 2023 10:44:21 -0800 (PST) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231104145700.2495176-1-gary@garyguo.net> In-Reply-To: <20231104145700.2495176-1-gary@garyguo.net> From: Miguel Ojeda Date: Wed, 13 Dec 2023 19:44:10 +0100 Message-ID: Subject: Re: [PATCH v2] rust: bindings: rename const binding using sed To: Gary Guo Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Martin Rodriguez Reboredo , Vincenzo Palazzo , Wedson Almeida Filho , Vlastimil Babka , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Nov 4, 2023 at 3:58=E2=80=AFPM Gary Guo wrote: > > This patch changes the way we define constant helpers to > > const RUST_CONST_HELPER_ =3D ; > > and then use `sed` to postprocess Rust code by generated by bindgen to > remove the distinct prefix, so user of the binding crate can refer to > the name directly. > > Reviewed-by: Benno Lossin > Reviewed-by: Andreas Hindborg > Reviewed-by: Martin Rodriguez Reboredo > Signed-off-by: Gary Guo Applied to `rust-next` (reworded for typos and with Benno's `^` suggestion -- we can always relax it back later if needed, the output is currently the same). Thanks everyone! Cheers, Miguel