From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Burak Emir <bqe@google.com>
Cc: "Jann Horn" <jannh@google.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Kees Cook" <kees@kernel.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v8 3/5] rust: add bitmap API.
Date: Mon, 19 May 2025 23:42:01 +0200 [thread overview]
Message-ID: <CANiq72k6vhzR8W72B-vqHy3rrTv+y9rYECx9bfHX=eD6TXye8A@mail.gmail.com> (raw)
In-Reply-To: <CACQBu=UNAFjKw_m8oE5Mst_eThEf36zqgUWZ3a0u1m4zr6MoJw@mail.gmail.com>
On Mon, May 19, 2025 at 10:08 PM Burak Emir <bqe@google.com> wrote:
>
> The "unsafe" here should serve as reminder to argue why it is ok to
> not have any ordering guarantees.
`unsafe` should be used for unsafe functions, not as a general
"danger" or "advanced" marker.
(Having such a marker could be useful, but `unsafe fn` is not it)
> The last sentence is supposed to say: when you have a &mut bitmap, you
> can reborrow it as &bitmap, and then happily call this atomic op.
> Even though it is unnecessary.
I don't think that is related to safety preconditions. A "# Safety"
section is intended to explain what the preconditions are.
So, for instance, stating "The caller must ensure that this is safe"
does not add much.
Cheers,
Miguel
next prev parent reply other threads:[~2025-05-19 21:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 16:17 [PATCH v8 0/5] rust: adds Bitmap API, ID pool and bindings Burak Emir
2025-05-19 16:17 ` [PATCH v8 1/5] rust: add bindings for bitmap.h Burak Emir
2025-05-19 16:17 ` [PATCH v8 2/5] rust: add bindings for bitops.h Burak Emir
2025-05-19 16:17 ` [PATCH v8 3/5] rust: add bitmap API Burak Emir
2025-05-19 18:22 ` Yury Norov
2025-05-19 20:41 ` Burak Emir
2025-05-19 20:51 ` Jann Horn
2025-05-19 22:07 ` Yury Norov
2025-05-19 19:00 ` Jann Horn
2025-05-19 20:07 ` Burak Emir
2025-05-19 20:09 ` Burak Emir
2025-05-19 20:36 ` Jann Horn
2025-05-19 20:49 ` Boqun Feng
2025-05-19 21:42 ` Miguel Ojeda [this message]
2025-05-19 21:49 ` Burak Emir
2025-05-20 5:59 ` kernel test robot
2025-05-19 16:17 ` [PATCH v8 4/5] rust: add find_bit_benchmark_rust module Burak Emir
2025-05-19 17:39 ` Yury Norov
2025-05-19 18:11 ` Miguel Ojeda
2025-05-19 16:17 ` [PATCH v8 5/5] rust: add dynamic ID pool abstraction for bitmap Burak Emir
2025-05-19 19:46 ` Yury Norov
2025-05-19 22:51 ` Jann Horn
2025-05-19 23:12 ` Alice Ryhl
2025-05-19 23:43 ` Jann Horn
2025-05-19 23:56 ` Boqun Feng
2025-05-20 0:57 ` Yury Norov
2025-05-20 3:45 ` Alice Ryhl
2025-05-21 3:57 ` Carlos Llamas
2025-05-21 13:50 ` Yury Norov
2025-05-26 14:22 ` Burak Emir
2025-05-20 3:46 ` Alice Ryhl
2025-05-20 5:21 ` Boqun Feng
2025-05-20 12:42 ` Alice Ryhl
2025-05-20 12:56 ` Boqun Feng
2025-05-20 13:05 ` Alice Ryhl
2025-05-20 13:21 ` Boqun Feng
2025-05-20 15:55 ` Jann Horn
2025-05-20 16:54 ` Boqun Feng
2025-05-20 19:43 ` Jann Horn
2025-05-19 18:34 ` [PATCH v8 0/5] rust: adds Bitmap API, ID pool and bindings Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72k6vhzR8W72B-vqHy3rrTv+y9rYECx9bfHX=eD6TXye8A@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bqe@google.com \
--cc=gary@garyguo.net \
--cc=gustavoars@kernel.org \
--cc=jannh@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).