From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Danilo Krummrich <dakr@kernel.org>,
FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <peterz@infradead.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Yury Norov" <yury.norov@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] rust: cpu: Introduce CpuId abstraction
Date: Tue, 10 Jun 2025 11:43:06 +0200 [thread overview]
Message-ID: <CANiq72kD9iQh6TPo3Rwk7AmPXEarogUrM2fmhkDn5XNfKrr_jw@mail.gmail.com> (raw)
In-Reply-To: <20250610060711.zp6lua4kcwi2z777@vireshk-i7>
On Tue, Jun 10, 2025 at 8:07 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> What do you suggest ?
I think you are right, we should keep both directions of conversion.
(By the way, as far as I understand there is no way we could wrap
going to `i32`, but it may not hurt to add a `debug_assert!` in the
`u32` constructors.)
> Sorry, not sure I understood that. Are you talking about type of the
> `cpu` argument ?
Yeah.
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2025-06-10 9:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 10:51 [PATCH V2 0/2] rust: Introduce CpuId and fix cpumask doctest Viresh Kumar
2025-06-09 10:51 ` [PATCH V2 1/2] rust: cpu: Introduce CpuId abstraction Viresh Kumar
2025-06-09 11:18 ` Viresh Kumar
2025-06-09 14:04 ` Boqun Feng
2025-06-10 8:39 ` Viresh Kumar
2025-06-09 12:01 ` Miguel Ojeda
2025-06-10 6:07 ` Viresh Kumar
2025-06-10 9:43 ` Miguel Ojeda [this message]
2025-06-10 10:18 ` Viresh Kumar
2025-06-10 10:23 ` Miguel Ojeda
2025-06-10 10:00 ` Viresh Kumar
2025-06-10 10:14 ` Miguel Ojeda
2025-06-10 10:21 ` Miguel Ojeda
2025-06-10 10:38 ` Viresh Kumar
2025-06-10 10:19 ` Viresh Kumar
2025-06-10 10:50 ` Miguel Ojeda
2025-06-09 10:51 ` [PATCH V2 2/2] rust: Use CpuId in place of raw CPU numbers Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kD9iQh6TPo3Rwk7AmPXEarogUrM2fmhkDn5XNfKrr_jw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).