From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Dirk Behme <dirk.behme@de.bosch.com>,
rust-for-linux@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH v3] docs: rust: Add rusttest info
Date: Fri, 15 Dec 2023 11:43:02 +0100 [thread overview]
Message-ID: <CANiq72kQYS2Z-tRwaH6SJHM5RY8D=TSsdSgufD9YmX2GfDgPeg@mail.gmail.com> (raw)
In-Reply-To: <6df6e8e5-8d5b-4d3d-91b5-bc0e90c424ea@nvidia.com>
On Wed, Dec 13, 2023 at 2:44 AM John Hubbard <jhubbard@nvidia.com> wrote:
>
> ah OK. I appear to have been slightly misled by
> Documentation/rust/quick-start.rst, which made it seem like CC=clang
> was...a thing. This excerpt made me do it:
Yeah, it is the "old way" for many architectures, but nowadays
`LLVM=1` is the recommended way for most (in the last couple years a
few architectures got promoted from `CC=clang` to `LLVM=1`).
Given that most arches are `LLVM=1` nowadays, including those that we
currently support Rust for, and that perhaps by the time e.g. s390
supports Rust it is also a `LLVM=1` architecture, we should probably
just remove `CC=clang` at this point and perhaps add an extra link to
Documentation/kbuild/llvm.rst again just in case (the link is also
elsewhere in that document, but I guess it does not hurt).
I will send a patch.
> Anyway, I wanted to provide this "how does the documentation look
> to a newcomer" feedback, in case it helps.
It does -- thanks a lot!
Cheers,
Miguel
next prev parent reply other threads:[~2023-12-15 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 12:16 [PATCH v3] docs: rust: Add rusttest info Dirk Behme
2023-12-11 12:30 ` Mika Westerberg
2023-12-11 14:54 ` Miguel Ojeda
2023-12-12 3:12 ` John Hubbard
2023-12-12 12:43 ` Miguel Ojeda
2023-12-12 18:11 ` Nathan Chancellor
2023-12-13 1:44 ` John Hubbard
2023-12-15 10:43 ` Miguel Ojeda [this message]
2023-12-15 12:52 ` Miguel Ojeda
2023-12-12 4:36 ` David Gow
2023-12-12 23:48 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72kQYS2Z-tRwaH6SJHM5RY8D=TSsdSgufD9YmX2GfDgPeg@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=jhubbard@nvidia.com \
--cc=nathan@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).