rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Aliet Exposito Garcia <aliet.exposito@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@samsung.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 0/2] rust: Move unfit code out of `rust/kernel/types.rs`
Date: Sat, 5 Oct 2024 21:48:07 +0200	[thread overview]
Message-ID: <CANiq72keixz_kVpUQMEFQcgewwrjcA_Od3E5-K9jF_UYFrg2aQ@mail.gmail.com> (raw)
In-Reply-To: <20240918225115.2309224-1-aliet.exposito@gmail.com>

On Thu, Sep 19, 2024 at 12:51 AM Aliet Exposito Garcia
<aliet.exposito@gmail.com> wrote:
>
> Hello all,
> These are the patches for a good first issue that Benno Lossin oppened
> on https://github.com/Rust-for-Linux/linux/issues/1117
> According to the issue description, the file `rust/kernel/types.rs` is a
> rather non-descriptive, general file that contains code that might be
> better suited elsewhere:
>  - `ARef<T>` and `AlwaysRefCounted` should be in `rust/kernel/sync/aref.rs`
>  - The `FromBytes` and `AsBytes` traits and implementations should be in
>     `rust/kernel/transmute.rs`

Applied to `rust-next` -- thanks everyone!

    [ Rebased on top of the lints series and slightly reworded. - Miguel ]

    [ Rebased on top of the lints series, slightly reworded and removed
      unneeded `use AlwaysRefCounted` in example. - Miguel ]

Aliet: please double-check that you are happy with the rebase.

Cheers,
Miguel

  parent reply	other threads:[~2024-10-05 19:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 22:51 [PATCH 0/2] rust: Move unfit code out of `rust/kernel/types.rs` Aliet Exposito Garcia
2024-09-18 22:51 ` [PATCH 1/2] rust: Move `FromBytes` and `AsBytes` traits to a new `transmute` module Aliet Exposito Garcia
2024-09-19 14:39   ` Benno Lossin
2024-09-20  9:20   ` Fiona Behrens
2024-09-18 22:51 ` [PATCH 2/2] rust: Move `ARef<T>` and `AlwaysRefCounted` to new `sync::aref` module Aliet Exposito Garcia
2024-09-19 14:39   ` Benno Lossin
2024-09-20  9:21   ` Fiona Behrens
2024-10-05 19:48 ` Miguel Ojeda [this message]
2024-10-06 19:29   ` [PATCH 0/2] rust: Move unfit code out of `rust/kernel/types.rs` Aliet Expósito
2024-10-07 17:11     ` Miguel Ojeda
2024-10-14 12:13   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72keixz_kVpUQMEFQcgewwrjcA_Od3E5-K9jF_UYFrg2aQ@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=a.hindborg@samsung.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=aliet.exposito@gmail.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).