From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B3D3B2B1; Tue, 17 Oct 2023 15:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="POQ3QGWu" Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6A1DFD; Tue, 17 Oct 2023 08:21:19 -0700 (PDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-5a7c93507d5so69198187b3.2; Tue, 17 Oct 2023 08:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697556079; x=1698160879; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xDhBgsohyNMQvgoVClOoX7HtBV2amiL9Qo+GoP49do4=; b=POQ3QGWumVGouV/dYmG00tv3UOAP+DciRLzg9ErdgnX0rnKVx1lqrc2m3P33fJdipi YXeBa2tlmgJLKGq9WGtF+dg9yogQCjTFIB+RPaF35Lu1cQCI7JYIYPzfOXBg8F9NF2g7 88MkjK9jywP5FtCWpoGDW/qqy2F9s8IsGbUJ01eplt67Rit637mdgQ3p9NNjtIJtDUGq KlKjc+4Pj3DZDfP2rbwo5MeL8xGAOm8aq3NqbIh+1OOK+FknvtF0ROsMuySS+CZ0vc5d YBF55K02s09n3P8F+kVYT+x60Qitd31K+IVzJf5gmcVf3i/3sxo1GoE2tQf6wRbOaM1c BQwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697556079; x=1698160879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xDhBgsohyNMQvgoVClOoX7HtBV2amiL9Qo+GoP49do4=; b=MRILaR+sF9u44l362pyV5xsylP2Y1kp/hM+7qr+SH0ZXi7uA7yanDOCzzfAdDrTuCn Ikh9XyAN9yMgdXezb+6c7fW75UE2Mis/APZejI6R2ewBpaqQrr4TCHlbgHdiyJW7+9Mx SwZgcrKj+X4jXZfGkSzFxZGQwZXV04mt7C0CktXc6WDfTga1smba5fIX0i+ABN1eE512 JHpW1trRIo/Yn6bA3yrEq9yDgslwo5L/XPRGqRqT7mT4jAmSr36jtTaRTHE70/5PmwCV phstOP7DUrnJiqpBXEUrCimJnV64p5aK0S8oEVOllZ5iUyExwo/q9RN1AJGJH3Lpm9s3 QOcg== X-Gm-Message-State: AOJu0Ywd2oIg/xgIJ2stSwG+y51Tng+oaM27DQeS3p5Ig0805BKbtihS n3vxMMaoGqtSXI0hMTzZnehrtHWTPnEG+oeZbgg= X-Google-Smtp-Source: AGHT+IFiunQfYo4Ll5L97FADwFB3QhJb7RORPsyhv1/0472jUhiU3gq14vu0tGA4HR7o2Wx5p/KM4it2UpUyOqFosTA= X-Received: by 2002:a81:738b:0:b0:59b:e449:2d51 with SMTP id o133-20020a81738b000000b0059be4492d51mr2478947ywc.49.1697556078990; Tue, 17 Oct 2023 08:21:18 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231017103742.130927-1-masahiroy@kernel.org> <20231017103742.130927-2-masahiroy@kernel.org> In-Reply-To: <20231017103742.130927-2-masahiroy@kernel.org> From: Miguel Ojeda Date: Tue, 17 Oct 2023 17:21:07 +0200 Message-ID: Subject: Re: [PATCH 2/4] kbuild: avoid too many execution of scripts/pahole-flags.sh To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Gaynor , Alexei Starovoitov , Alice Ryhl , Andreas Hindborg , Andrii Nakryiko , Benno Lossin , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng , Daniel Borkmann , Gary Guo , Hao Luo , Jiri Olsa , John Fastabend , KP Singh , Martin KaFai Lau , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Song Liu , Stanislav Fomichev , Wedson Almeida Filho , Yonghong Song , bpf@vger.kernel.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Oct 17, 2023 at 12:38=E2=80=AFPM Masahiro Yamada wrote: > > Convert the shell script to a Makefile, which is included only when > CONFIG_DEBUG_INFO_BTF=3Dy. > > [1]: https://savannah.gnu.org/bugs/index.php?64746 > > Signed-off-by: Masahiro Yamada The field in `MAINTAINERS` should be removed: F: scripts/pahole-flags.sh But other than that, it looks good to me! I tried it for a given config and it does call `pahole` with the same flags. Tested-by: Miguel Ojeda Acked-by: Miguel Ojeda Cheers, Miguel