From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alice Ryhl <alice@ryhl.io>, FUJITA Tomonori <tomo@exabit.dev>,
rust-for-linux@vger.kernel.org, aliceryhl@google.com,
FUJITA Tomonori <fujita.tomonori@gmail.com>,
Andreas Hindborg <a.hindborg@samsung.com>
Subject: Re: [PATCH v2 1/5] rust: core abstractions for network device drivers
Date: Sun, 11 Jun 2023 19:48:04 +0200 [thread overview]
Message-ID: <CANiq72kyUhvmG6KB32X1vuhNzOOJbs7R1JbK+vnPELX4tG73RA@mail.gmail.com> (raw)
In-Reply-To: <1d3ade6a-1333-4729-a8e1-13e2aceeeb12@lunn.ch>
On Sun, Jun 11, 2023 at 6:01 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> Ah, thanks for the explanation.
>
> This is going to be a problem for networking. The hot path has a lot
> of inline functions, because a function call is expensive. So there
> are going to be a lot of little wrappers like this. I don't want to
> encourage early optimisation without proper profiling, but at some
> point you might want to replace these wrappers with Rust, using
> whatever its equivalent of inline is.
Yeah, other use cases will also need that solved, e.g. Andreas for his
NVMe work.
We discussed reimplementing performance-critical bits in Rust as you
suggest, as well as cross-language LTO. We also talked about possible
alternative approaches like "manual local LTO" for the helpers only
via feeding their LLVM IR to `rustc`, which may recover most of the
performance without having to go for full LTO and its associated
kernel link times.
Cheers,
Miguel
next prev parent reply other threads:[~2023-06-11 17:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230610071848.3722492-1-tomo@exabit.dev>
2023-06-10 7:20 ` [PATCH v2 1/5] rust: core abstractions for network device drivers FUJITA Tomonori
2023-06-10 14:11 ` Andrew Lunn
2023-06-11 8:03 ` Alice Ryhl
2023-06-11 15:30 ` Andrew Lunn
2023-06-11 17:48 ` Miguel Ojeda [this message]
2023-06-12 6:47 ` FUJITA Tomonori
2023-06-12 12:46 ` Andrew Lunn
2023-06-10 19:49 ` Miguel Ojeda
2023-06-12 5:04 ` FUJITA Tomonori
2023-06-12 13:26 ` Miguel Ojeda
2023-06-10 7:20 ` [PATCH v2 2/5] rust: add support for ethernet operations FUJITA Tomonori
2023-06-10 16:48 ` Andrew Lunn
2023-06-12 6:51 ` FUJITA Tomonori
2023-06-10 19:14 ` Miguel Ojeda
2023-06-12 8:51 ` FUJITA Tomonori
2023-06-12 13:35 ` Miguel Ojeda
2023-06-10 7:20 ` [PATCH v2 5/5] samples: rust: add dummy network driver FUJITA Tomonori
2023-06-10 16:59 ` Andrew Lunn
2023-06-12 7:02 ` FUJITA Tomonori
2023-06-10 19:14 ` Miguel Ojeda
2023-06-10 7:20 ` [PATCH v2 3/5] rust: add support for get_stats64 in struct net_device_ops FUJITA Tomonori
2023-06-10 7:20 ` [PATCH v2 4/5] rust: add methods for configure net_device FUJITA Tomonori
2023-07-10 7:36 [PATCH v2 0/5] Rust abstractions for network device drivers FUJITA Tomonori
2023-07-10 7:36 ` [PATCH v2 1/5] rust: core " FUJITA Tomonori
2023-07-14 18:59 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kyUhvmG6KB32X1vuhNzOOJbs7R1JbK+vnPELX4tG73RA@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alice@ryhl.io \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=fujita.tomonori@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tomo@exabit.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).